Re: [Mesa-dev] [PATCH 2/2] mesa: rearrange texture error checking order

2015-07-23 Thread Ilia Mirkin
On Thu, Jul 23, 2015 at 6:49 PM, Brian Paul wrote: > On 07/23/2015 04:37 PM, Ilia Mirkin wrote: >> >> On Thu, Jul 23, 2015 at 6:34 PM, Brian Paul wrote: >>> >>> On 07/23/2015 04:24 PM, Ilia Mirkin wrote: On Wed, Jul 22, 2015 at 1:44 PM, Brian Paul wrote: > > > On 07/22

Re: [Mesa-dev] [PATCH 2/2] mesa: rearrange texture error checking order

2015-07-23 Thread Brian Paul
On 07/23/2015 04:37 PM, Ilia Mirkin wrote: On Thu, Jul 23, 2015 at 6:34 PM, Brian Paul wrote: On 07/23/2015 04:24 PM, Ilia Mirkin wrote: On Wed, Jul 22, 2015 at 1:44 PM, Brian Paul wrote: On 07/22/2015 11:29 AM, Ilia Mirkin wrote: On Wed, Jul 22, 2015 at 1:20 PM, Brian Paul wrote: O

Re: [Mesa-dev] [PATCH 2/2] mesa: rearrange texture error checking order

2015-07-23 Thread Ilia Mirkin
On Thu, Jul 23, 2015 at 6:34 PM, Brian Paul wrote: > On 07/23/2015 04:24 PM, Ilia Mirkin wrote: >> >> On Wed, Jul 22, 2015 at 1:44 PM, Brian Paul wrote: >>> >>> On 07/22/2015 11:29 AM, Ilia Mirkin wrote: On Wed, Jul 22, 2015 at 1:20 PM, Brian Paul wrote: > > > On 07/22

Re: [Mesa-dev] [PATCH 2/2] mesa: rearrange texture error checking order

2015-07-23 Thread Brian Paul
On 07/23/2015 04:24 PM, Ilia Mirkin wrote: On Wed, Jul 22, 2015 at 1:44 PM, Brian Paul wrote: On 07/22/2015 11:29 AM, Ilia Mirkin wrote: On Wed, Jul 22, 2015 at 1:20 PM, Brian Paul wrote: On 07/22/2015 11:02 AM, Ilia Mirkin wrote: This moves the width/height/depth == 0 check to the fron

Re: [Mesa-dev] [PATCH 2/2] mesa: rearrange texture error checking order

2015-07-23 Thread Ilia Mirkin
On Wed, Jul 22, 2015 at 1:44 PM, Brian Paul wrote: > On 07/22/2015 11:29 AM, Ilia Mirkin wrote: >> >> On Wed, Jul 22, 2015 at 1:20 PM, Brian Paul wrote: >>> >>> On 07/22/2015 11:02 AM, Ilia Mirkin wrote: This moves the width/height/depth == 0 check to the front and avoids doin

Re: [Mesa-dev] [PATCH 2/2] mesa: rearrange texture error checking order

2015-07-22 Thread Brian Paul
On 07/22/2015 11:29 AM, Ilia Mirkin wrote: On Wed, Jul 22, 2015 at 1:20 PM, Brian Paul wrote: On 07/22/2015 11:02 AM, Ilia Mirkin wrote: This moves the width/height/depth == 0 check to the front and avoids doing any other checking when that is the case. Also moves the dimensions check after

Re: [Mesa-dev] [PATCH 2/2] mesa: rearrange texture error checking order

2015-07-22 Thread Ilia Mirkin
On Wed, Jul 22, 2015 at 1:20 PM, Brian Paul wrote: > On 07/22/2015 11:02 AM, Ilia Mirkin wrote: >> >> This moves the width/height/depth == 0 check to the front and avoids >> doing any other checking when that is the case. >> >> Also moves the dimensions check after the format/type checks so that w

Re: [Mesa-dev] [PATCH 2/2] mesa: rearrange texture error checking order

2015-07-22 Thread Brian Paul
On 07/22/2015 11:02 AM, Ilia Mirkin wrote: This moves the width/height/depth == 0 check to the front and avoids doing any other checking when that is the case. Also moves the dimensions check after the format/type checks so that we don't bail out with success on a width/height/depth == 0 request

[Mesa-dev] [PATCH 2/2] mesa: rearrange texture error checking order

2015-07-22 Thread Ilia Mirkin
This moves the width/height/depth == 0 check to the front and avoids doing any other checking when that is the case. Also moves the dimensions check after the format/type checks so that we don't bail out with success on a width/height/depth == 0 request when the format/type don't match. Bugzilla: