Re: [Mesa-dev] [PATCH 2/2] mesa: Add test for sorted extension table

2015-11-18 Thread Ian Romanick
On 11/18/2015 03:01 PM, Nanley Chery wrote: > From: Nanley Chery > > Enable developers to know if the table's alphabetical sorting > is maintained or lost. I like this in principle, but let's be honest. Almost all of the time, the people who don't sort (by whatever order we agree) also don't ru

Re: [Mesa-dev] [PATCH 2/2] mesa: Add test for sorted extension table

2015-11-18 Thread Emil Velikov
On 19 November 2015 at 00:16, Nanley Chery wrote: > On Wed, Nov 18, 2015 at 4:08 PM, Emil Velikov > wrote: >> >> On 18 November 2015 at 23:40, Nanley Chery wrote: >> > On Wed, Nov 18, 2015 at 3:07 PM, Ilia Mirkin >> > wrote: >> >> >> >> Why have the count as an entry in the enum? Can't you just

Re: [Mesa-dev] [PATCH 2/2] mesa: Add test for sorted extension table

2015-11-18 Thread Matt Turner
On Wed, Nov 18, 2015 at 4:08 PM, Emil Velikov wrote: > On 18 November 2015 at 23:40, Nanley Chery wrote: >> On Wed, Nov 18, 2015 at 3:07 PM, Ilia Mirkin wrote: >>> >>> Why have the count as an entry in the enum? Can't you just do >>> ARRAY_SIZE(_mesa_extension_table) ? >>> >> >> The compiler doe

Re: [Mesa-dev] [PATCH 2/2] mesa: Add test for sorted extension table

2015-11-18 Thread Nanley Chery
On Wed, Nov 18, 2015 at 4:08 PM, Emil Velikov wrote: > On 18 November 2015 at 23:40, Nanley Chery wrote: > > On Wed, Nov 18, 2015 at 3:07 PM, Ilia Mirkin > wrote: > >> > >> Why have the count as an entry in the enum? Can't you just do > >> ARRAY_SIZE(_mesa_extension_table) ? > >> > > > > The co

Re: [Mesa-dev] [PATCH 2/2] mesa: Add test for sorted extension table

2015-11-18 Thread Emil Velikov
On 18 November 2015 at 23:40, Nanley Chery wrote: > On Wed, Nov 18, 2015 at 3:07 PM, Ilia Mirkin wrote: >> >> Why have the count as an entry in the enum? Can't you just do >> ARRAY_SIZE(_mesa_extension_table) ? >> > > The compiler doesn't know the size of the array by just looking at the > header

Re: [Mesa-dev] [PATCH 2/2] mesa: Add test for sorted extension table

2015-11-18 Thread Matt Turner
On Wed, Nov 18, 2015 at 3:01 PM, Nanley Chery wrote: > From: Nanley Chery > > Enable developers to know if the table's alphabetical sorting > is maintained or lost. My hero. > Signed-off-by: Nanley Chery > --- > src/mesa/main/extensions.h | 1 + > src/mesa/main/tests/Makefile.am

Re: [Mesa-dev] [PATCH 2/2] mesa: Add test for sorted extension table

2015-11-18 Thread Nanley Chery
On Wed, Nov 18, 2015 at 3:07 PM, Ilia Mirkin wrote: > Why have the count as an entry in the enum? Can't you just do > ARRAY_SIZE(_mesa_extension_table) ? > > The compiler doesn't know the size of the array by just looking at the header. To use ARRAY_SIZE, I'd have to modify the declaration of _me

Re: [Mesa-dev] [PATCH 2/2] mesa: Add test for sorted extension table

2015-11-18 Thread Ilia Mirkin
Why have the count as an entry in the enum? Can't you just do ARRAY_SIZE(_mesa_extension_table) ? On Wed, Nov 18, 2015 at 6:01 PM, Nanley Chery wrote: > From: Nanley Chery > > Enable developers to know if the table's alphabetical sorting > is maintained or lost. > > Signed-off-by: Nanley Chery

[Mesa-dev] [PATCH 2/2] mesa: Add test for sorted extension table

2015-11-18 Thread Nanley Chery
From: Nanley Chery Enable developers to know if the table's alphabetical sorting is maintained or lost. Signed-off-by: Nanley Chery --- src/mesa/main/extensions.h | 1 + src/mesa/main/tests/Makefile.am | 1 + src/mesa/main/tests/mesa_extensions.cpp | 47 +