Re: [Mesa-dev] [PATCH 2/2] mesa/glsl: rename preprocess to glcpp_preprocess

2012-09-14 Thread Mathias Fröhlich
Hi, On Friday, September 14, 2012 00:08:27 Kenneth Graunke wrote: > I wonder if there's something better we can do. I don't know what though. Is there any deep reason why we use RTLD_GLOBAL for dlopening the drivers? If not we could use RTLD_LOCAL | RTLD_DEEPBIND instead of RTLD_GLOBAL. This

Re: [Mesa-dev] [PATCH 2/2] mesa/glsl: rename preprocess to glcpp_preprocess

2012-09-14 Thread Kenneth Graunke
On 09/13/2012 11:44 PM, Dave Airlie wrote: > On Fri, Sep 14, 2012 at 4:36 PM, Kenneth Graunke > wrote: >> On 09/13/2012 05:13 PM, Dave Airlie wrote: >>> From: Dave Airlie >>> >>> This symbol with dricore escapes into the namespace, its too generic, >>> we should prefix it with something just to

Re: [Mesa-dev] [PATCH 2/2] mesa/glsl: rename preprocess to glcpp_preprocess

2012-09-13 Thread Dave Airlie
On Fri, Sep 14, 2012 at 4:36 PM, Kenneth Graunke wrote: > On 09/13/2012 05:13 PM, Dave Airlie wrote: >> From: Dave Airlie >> >> This symbol with dricore escapes into the namespace, its too generic, >> we should prefix it with something just to be nice. >> >> Should be applied to stable + 9.0 >> >

Re: [Mesa-dev] [PATCH 2/2] mesa/glsl: rename preprocess to glcpp_preprocess

2012-09-13 Thread Kenneth Graunke
On 09/13/2012 05:13 PM, Dave Airlie wrote: > From: Dave Airlie > > This symbol with dricore escapes into the namespace, its too generic, > we should prefix it with something just to be nice. > > Should be applied to stable + 9.0 > > Signed-off-by: Dave Airlie Forgive me for not understanding

[Mesa-dev] [PATCH 2/2] mesa/glsl: rename preprocess to glcpp_preprocess

2012-09-13 Thread Dave Airlie
From: Dave Airlie This symbol with dricore escapes into the namespace, its too generic, we should prefix it with something just to be nice. Should be applied to stable + 9.0 Signed-off-by: Dave Airlie --- src/glsl/glcpp/glcpp.c |2 +- src/glsl/glcpp/glcpp.h |2 +- sr