Re: [Mesa-dev] [PATCH 2/2] intel: initialize fs_visitor::params_remap in constructor

2013-05-29 Thread Dave Airlie
On Tue, Jan 29, 2013 at 12:52 PM, Ian Romanick wrote: > On 01/28/2013 05:06 PM, Frank Henigman wrote: >> >> Set fs_visitor::params_remap to NULL in the constructor. >> This variable was potentially tested in >> fs_visitor::remove_dead_constants() >> before being set. >> >> Signed-off-by: Frank Hen

Re: [Mesa-dev] [PATCH 2/2] intel: initialize fs_visitor::params_remap in constructor

2013-01-28 Thread Ian Romanick
On 01/28/2013 05:06 PM, Frank Henigman wrote: Set fs_visitor::params_remap to NULL in the constructor. This variable was potentially tested in fs_visitor::remove_dead_constants() before being set. Signed-off-by: Frank Henigman This patch is Reviewed-by: Ian Romanick Also, please add the fo

[Mesa-dev] [PATCH 2/2] intel: initialize fs_visitor::params_remap in constructor

2013-01-28 Thread Frank Henigman
Set fs_visitor::params_remap to NULL in the constructor. This variable was potentially tested in fs_visitor::remove_dead_constants() before being set. Signed-off-by: Frank Henigman --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/dri