Re: [Mesa-dev] [PATCH 2/2] i965/fs: Silence uninitialized variable warning.

2014-10-02 Thread Jason Ekstrand
On Tue, Sep 30, 2014 at 5:00 PM, Matt Turner wrote: > On Tue, Sep 30, 2014 at 4:24 PM, Matt Turner wrote: > > The compiler isn't privy to the knowledge that we're doing at least one > > framebuffer write. > > --- > > src/mesa/drivers/dri/i965/brw_fs.cpp | 1 + > > 1 file changed, 1 insertion(+)

Re: [Mesa-dev] [PATCH 2/2] i965/fs: Silence uninitialized variable warning.

2014-10-01 Thread Matt Turner
On Tue, Sep 30, 2014 at 4:24 PM, Matt Turner wrote: > The compiler isn't privy to the knowledge that we're doing at least one > framebuffer write. > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp > b/src/me

Re: [Mesa-dev] [PATCH 2/2] i965/fs: Silence uninitialized variable warning.

2014-10-01 Thread Matt Turner
On Tue, Sep 30, 2014 at 5:18 PM, Jason Ekstrand wrote: > Reviewed-by: Jason Ekstrand The patch is wrong. See my reply. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] i965/fs: Silence uninitialized variable warning.

2014-10-01 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Tue, Sep 30, 2014 at 4:24 PM, Matt Turner wrote: > The compiler isn't privy to the knowledge that we're doing at least one > framebuffer write. > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/mesa/drivers/

Re: [Mesa-dev] [PATCH 2/2] i965/fs: Silence uninitialized variable warning.

2014-09-30 Thread Jason Ekstrand
On Tue, Sep 30, 2014 at 5:26 PM, Matt Turner wrote: > On Tue, Sep 30, 2014 at 5:18 PM, Jason Ekstrand > wrote: > > Reviewed-by: Jason Ekstrand > > The patch is wrong. See my reply. > Hunh? Reply to what? ___ mesa-dev mailing list mesa-dev@lists.freed

[Mesa-dev] [PATCH 2/2] i965/fs: Silence uninitialized variable warning.

2014-09-30 Thread Matt Turner
The compiler isn't privy to the knowledge that we're doing at least one framebuffer write. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 19e9cb9..d113812 100644 --- a/s