Re: [Mesa-dev] [PATCH 2/2] glsl: don't recompile a shader on fallback unless needed

2017-03-11 Thread Timothy Arceri
On 10/03/17 22:53, Marek Olšák wrote: For the series: Acked-by: Marek Olšák Thanks :) Does this fix the crash when GLSL gets a cache hit and st/mesa gets a cache miss? There is no crash that I'm aware of. If you mean does the fallback path stop such a crash happening then yes. Mar

Re: [Mesa-dev] [PATCH 2/2] glsl: don't recompile a shader on fallback unless needed

2017-03-10 Thread Marek Olšák
For the series: Acked-by: Marek Olšák Does this fix the crash when GLSL gets a cache hit and st/mesa gets a cache miss? Marek On Thu, Mar 9, 2017 at 1:42 PM, Timothy Arceri wrote: > On 09/03/17 22:58, Timothy Arceri wrote: >> >> Because we optimistically skip compiling shaders if we have see

Re: [Mesa-dev] [PATCH 2/2] glsl: don't recompile a shader on fallback unless needed

2017-03-09 Thread Timothy Arceri
On 09/03/17 22:58, Timothy Arceri wrote: Because we optimistically skip compiling shaders if we have seen them before we may need to compile them later at link time if they haven't yet been use in a specific combination to create a program. Rather than always recompiling we take advantage of the

[Mesa-dev] [PATCH 2/2] glsl: don't recompile a shader on fallback unless needed

2017-03-09 Thread Timothy Arceri
Because we optimistically skip compiling shaders if we have seen them before we may need to compile them later at link time if they haven't yet been use in a specific combination to create a program. Rather than always recompiling we take advantage of the gl_compile_status enum introduced in the p