Re: [Mesa-dev] [PATCH 2/2] gallium/u_gen_mipmap: rewrite using pipe->blit (v2)

2014-04-07 Thread Roland Scheidegger
Just a trivial comment, otherwise looks good to me. Thanks! Roland Am 07.04.2014 21:05, schrieb Marek Olšák: > From: Marek Olšák > > This replaces u_gen_mipmap with an extremely simple implementation based > on pipe->blit. st/mesa is also cleaned up. > > Pros: > - less code > - correct mipmap

[Mesa-dev] [PATCH 2/2] gallium/u_gen_mipmap: rewrite using pipe->blit (v2)

2014-04-07 Thread Marek Olšák
From: Marek Olšák This replaces u_gen_mipmap with an extremely simple implementation based on pipe->blit. st/mesa is also cleaned up. Pros: - less code - correct mipmap generation for NPOT 3D textures (u_blitter uses a better formula) - queries are not affected by mipmap generation if drivers

Re: [Mesa-dev] [PATCH 2/2] gallium/u_gen_mipmap: rewrite using pipe->blit (v2)

2014-04-04 Thread Roland Scheidegger
Am 05.04.2014 03:10, schrieb Marek Olšák: > From: Marek Olšák > > This replaces u_gen_mipmap with an extremely simple implementation based > on pipe->blit. st/mesa is also cleaned up. > > Pros: > - less code > - correct mipmap generation for NPOT 3D textures (u_blitter uses a better > formula)

[Mesa-dev] [PATCH 2/2] gallium/u_gen_mipmap: rewrite using pipe->blit (v2)

2014-04-04 Thread Marek Olšák
From: Marek Olšák This replaces u_gen_mipmap with an extremely simple implementation based on pipe->blit. st/mesa is also cleaned up. Pros: - less code - correct mipmap generation for NPOT 3D textures (u_blitter uses a better formula) - queries are not affected by mipmap generation if drivers