Re: [Mesa-dev] [PATCH 2/2] gallium/draw: add limits to the clip and cull distances

2013-06-12 Thread Jose Fonseca
- Original Message - [...] > On an unrelated note ... packing clip distances into vec4s sucks, I want > scalar arrays. OMG, then we must fix it! Now seriously, we had the discussion about packed vs unpacked clip distances -- I don't feel strongly either way and I don't recall the ration

Re: [Mesa-dev] [PATCH 2/2] gallium/draw: add limits to the clip and cull distances

2013-06-12 Thread Christoph Bumiller
On 12.06.2013 15:57, Jose Fonseca wrote: > > > - Original Message - >> Am 11.06.2013 05:39, schrieb Zack Rusin: >>> There are strict limits on those registers. Define the maximums >>> and use them instead of magic numbers. Also allows us to add >>> some extra sanity checks. >>> Suggested

Re: [Mesa-dev] [PATCH 2/2] gallium/draw: add limits to the clip and cull distances

2013-06-12 Thread Jose Fonseca
- Original Message - > Am 11.06.2013 05:39, schrieb Zack Rusin: > > There are strict limits on those registers. Define the maximums > > and use them instead of magic numbers. Also allows us to add > > some extra sanity checks. > > Suggested by Brian. > > > > Signed-off-by: Zack Rusin >

Re: [Mesa-dev] [PATCH 2/2] gallium/draw: add limits to the clip and cull distances

2013-06-11 Thread Roland Scheidegger
Am 11.06.2013 05:39, schrieb Zack Rusin: > There are strict limits on those registers. Define the maximums > and use them instead of magic numbers. Also allows us to add > some extra sanity checks. > Suggested by Brian. > > Signed-off-by: Zack Rusin > --- > src/gallium/auxiliary/draw/draw_contex

[Mesa-dev] [PATCH 2/2] gallium/draw: add limits to the clip and cull distances

2013-06-11 Thread Zack Rusin
There are strict limits on those registers. Define the maximums and use them instead of magic numbers. Also allows us to add some extra sanity checks. Suggested by Brian. Signed-off-by: Zack Rusin --- src/gallium/auxiliary/draw/draw_context.c |2 ++ src/gallium/auxiliary/draw/draw_gs.c