Re: [Mesa-dev] [PATCH 2/2] egl/dri2/drm: compact existing device mgmt

2015-09-07 Thread Boyan Ding
2015-09-07 16:58 GMT+08:00 Emil Velikov : > Move the fcntl(dupfd_cloexec) to the else branch where it belongs. > Otherwise it's not immediately obvious that the code is hit, only when > an existing device is used. A potential problem here. The fd acquired from gbm device provided as platform displ

[Mesa-dev] [PATCH 2/2] egl/dri2/drm: compact existing device mgmt

2015-09-07 Thread Emil Velikov
Move the fcntl(dupfd_cloexec) to the else branch where it belongs. Otherwise it's not immediately obvious that the code is hit, only when an existing device is used. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_drm.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(