Re: [Mesa-dev] [PATCH 2/2] automake: Remove OPT_FLAGS.

2012-07-26 Thread Marek Olšák
Ah, I see. Thank you for the clarification. Marek On Fri, Jul 27, 2012 at 12:29 AM, Eric Anholt wrote: > Marek Olšák writes: > >> Michel Dänzer told me on IRC that setting CFLAGS overrode all flags, >> while OPT_FLAGS was only appended to existing CFLAGS, which is the >> reason I have been usin

Re: [Mesa-dev] [PATCH 2/2] automake: Remove OPT_FLAGS.

2012-07-26 Thread Eric Anholt
Marek Olšák writes: > Michel Dänzer told me on IRC that setting CFLAGS overrode all flags, > while OPT_FLAGS was only appended to existing CFLAGS, which is the > reason I have been using OPT_FLAGS. Is that not true anymore? By default, configure's CFLAGS and CXXFLAGS are "-g -O2" on gcc and "-O2

Re: [Mesa-dev] [PATCH 2/2] automake: Remove OPT_FLAGS.

2012-07-26 Thread Marek Olšák
Michel Dänzer told me on IRC that setting CFLAGS overrode all flags, while OPT_FLAGS was only appended to existing CFLAGS, which is the reason I have been using OPT_FLAGS. Is that not true anymore? Marek On Thu, Jul 26, 2012 at 6:52 PM, Eric Anholt wrote: > If you want to change your compiler ar

Re: [Mesa-dev] [PATCH 2/2] automake: Remove OPT_FLAGS.

2012-07-26 Thread Kenneth Graunke
On 07/26/2012 09:52 AM, Eric Anholt wrote: > If you want to change your compiler arguments, just set CFLAGS/CXXFLAGS. > Having Mesa have this separate variable is a great way to have your arguments > not thoroughly propagated to all compiler invocations. > --- > > I don't feel strongly about remov

Re: [Mesa-dev] [PATCH 2/2] automake: Remove OPT_FLAGS.

2012-07-26 Thread Brian Paul
On 07/26/2012 10:52 AM, Eric Anholt wrote: If you want to change your compiler arguments, just set CFLAGS/CXXFLAGS. Having Mesa have this separate variable is a great way to have your arguments not thoroughly propagated to all compiler invocations. --- I don't feel strongly about removing the va

Re: [Mesa-dev] [PATCH 2/2] automake: Remove OPT_FLAGS.

2012-07-26 Thread Matt Turner
On Thu, Jul 26, 2012 at 9:52 AM, Eric Anholt wrote: > If you want to change your compiler arguments, just set CFLAGS/CXXFLAGS. > Having Mesa have this separate variable is a great way to have your arguments > not thoroughly propagated to all compiler invocations. > --- Reviewed-by: Matt Turner _

[Mesa-dev] [PATCH 2/2] automake: Remove OPT_FLAGS.

2012-07-26 Thread Eric Anholt
If you want to change your compiler arguments, just set CFLAGS/CXXFLAGS. Having Mesa have this separate variable is a great way to have your arguments not thoroughly propagated to all compiler invocations. --- I don't feel strongly about removing the variable from configure, just as long as we don