Re: [Mesa-dev] [PATCH 2/2] anv: Add support for shaderStorageImageWriteWithoutFormat

2017-02-13 Thread Jason Ekstrand
On Mon, Feb 13, 2017 at 9:40 AM, Alex Smith wrote: > Hi Lionel, > > On 13 February 2017 at 17:28, Lionel Landwerlin < > lionel.g.landwer...@intel.com> wrote: > >> On 09/02/17 16:06, Alex Smith wrote: >> >>> This allows shaders to write to storage images declared with unknown >>> format if they ar

Re: [Mesa-dev] [PATCH 2/2] anv: Add support for shaderStorageImageWriteWithoutFormat

2017-02-13 Thread Alex Smith
Hi Lionel, On 13 February 2017 at 17:28, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > On 09/02/17 16:06, Alex Smith wrote: > >> This allows shaders to write to storage images declared with unknown >> format if they are decorated with NonReadable ("writeonly" in GLSL). >> >> Previou

Re: [Mesa-dev] [PATCH 2/2] anv: Add support for shaderStorageImageWriteWithoutFormat

2017-02-13 Thread Alex Smith
Hi Jason, On 13 February 2017 at 16:10, Jason Ekstrand wrote: > Hey Alex, > > Thanks for the patch! I've made a couple of comments below but otherwise > this looks fantastic! I've thought a few times about how we would > implement this and what you've come up with is almost exactly what I woul

Re: [Mesa-dev] [PATCH 2/2] anv: Add support for shaderStorageImageWriteWithoutFormat

2017-02-13 Thread Jason Ekstrand
On Mon, Feb 13, 2017 at 9:28 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > On 09/02/17 16:06, Alex Smith wrote: > >> This allows shaders to write to storage images declared with unknown >> format if they are decorated with NonReadable ("writeonly" in GLSL). >> >> Previously an im

Re: [Mesa-dev] [PATCH 2/2] anv: Add support for shaderStorageImageWriteWithoutFormat

2017-02-13 Thread Lionel Landwerlin
On 09/02/17 16:06, Alex Smith wrote: This allows shaders to write to storage images declared with unknown format if they are decorated with NonReadable ("writeonly" in GLSL). Previously an image view would always use a lowered format for its surface state, however when a shader declares a write-

Re: [Mesa-dev] [PATCH 2/2] anv: Add support for shaderStorageImageWriteWithoutFormat

2017-02-13 Thread Jason Ekstrand
Hey Alex, Thanks for the patch! I've made a couple of comments below but otherwise this looks fantastic! I've thought a few times about how we would implement this and what you've come up with is almost exactly what I would have done. :-) On Thu, Feb 9, 2017 at 8:06 AM, Alex Smith wrote: > Th

[Mesa-dev] [PATCH 2/2] anv: Add support for shaderStorageImageWriteWithoutFormat

2017-02-09 Thread Alex Smith
This allows shaders to write to storage images declared with unknown format if they are decorated with NonReadable ("writeonly" in GLSL). Previously an image view would always use a lowered format for its surface state, however when a shader declares a write-only image, we should use the real form