Re: [Mesa-dev] [PATCH 2/2] android: fix spirv_info generation

2017-07-20 Thread Emil Velikov
On 20 July 2017 at 11:02, Chih-Wei Huang wrote: > 2017-07-19 15:12 GMT+08:00 Tapani Pälli : >> Depending on build order, LOCAL_PATH maybe set or not (and can't >> be trusted to have assumed path), change modifies all occurences >> of LOCAL_PATH as locally defined COMPILER_PATH instead. >> >> Signe

Re: [Mesa-dev] [PATCH 2/2] android: fix spirv_info generation

2017-07-20 Thread Chih-Wei Huang
2017-07-20 18:02 GMT+08:00 Chih-Wei Huang : > > OK. I see the real problem. > The rules to build spirv_info.c are incorrectly > to use $(LOCAL_PATH). > Basically speaking, $(LOCAL_PATH) can't be used > in the recipes[1] since it is always changing. > When the recipe rules are executed its value > i

Re: [Mesa-dev] [PATCH 2/2] android: fix spirv_info generation

2017-07-20 Thread Chih-Wei Huang
2017-07-19 15:12 GMT+08:00 Tapani Pälli : > Depending on build order, LOCAL_PATH maybe set or not (and can't > be trusted to have assumed path), change modifies all occurences > of LOCAL_PATH as locally defined COMPILER_PATH instead. > > Signed-off-by: Tapani Pälli > --- > src/compiler/Android.ni

Re: [Mesa-dev] [PATCH 2/2] android: fix spirv_info generation

2017-07-19 Thread Tapani Pälli
On 07/19/2017 05:01 PM, Rob Herring wrote: On Wed, Jul 19, 2017 at 8:56 AM, Emil Velikov wrote: On 19 July 2017 at 14:14, Tapani Pälli wrote: On 07/19/2017 03:29 PM, Emil Velikov wrote: On 19 July 2017 at 08:12, Tapani Pälli wrote: Depending on build order, LOCAL_PATH maybe set or not

Re: [Mesa-dev] [PATCH 2/2] android: fix spirv_info generation

2017-07-19 Thread Rob Herring
On Wed, Jul 19, 2017 at 8:56 AM, Emil Velikov wrote: > On 19 July 2017 at 14:14, Tapani Pälli wrote: >> On 07/19/2017 03:29 PM, Emil Velikov wrote: >>> >>> On 19 July 2017 at 08:12, Tapani Pälli wrote: Depending on build order, LOCAL_PATH maybe set or not (and can't be trusted to

Re: [Mesa-dev] [PATCH 2/2] android: fix spirv_info generation

2017-07-19 Thread Emil Velikov
On 19 July 2017 at 14:14, Tapani Pälli wrote: > On 07/19/2017 03:29 PM, Emil Velikov wrote: >> >> On 19 July 2017 at 08:12, Tapani Pälli wrote: >>> >>> Depending on build order, LOCAL_PATH maybe set or not (and can't >>> be trusted to have assumed path), change modifies all occurences >>> of LOCA

Re: [Mesa-dev] [PATCH 2/2] android: fix spirv_info generation

2017-07-19 Thread Tapani Pälli
On 07/19/2017 03:29 PM, Emil Velikov wrote: On 19 July 2017 at 08:12, Tapani Pälli wrote: Depending on build order, LOCAL_PATH maybe set or not (and can't be trusted to have assumed path), change modifies all occurences of LOCAL_PATH as locally defined COMPILER_PATH instead. Sounds like a bug

Re: [Mesa-dev] [PATCH 2/2] android: fix spirv_info generation

2017-07-19 Thread Emil Velikov
On 19 July 2017 at 08:12, Tapani Pälli wrote: > Depending on build order, LOCAL_PATH maybe set or not (and can't > be trusted to have assumed path), change modifies all occurences > of LOCAL_PATH as locally defined COMPILER_PATH instead. > Sounds like a bug somewhere or a fundamental breakage in t

[Mesa-dev] [PATCH 2/2] android: fix spirv_info generation

2017-07-19 Thread Tapani Pälli
Depending on build order, LOCAL_PATH maybe set or not (and can't be trusted to have assumed path), change modifies all occurences of LOCAL_PATH as locally defined COMPILER_PATH instead. Signed-off-by: Tapani Pälli --- src/compiler/Android.nir.gen.mk | 38 -- 1