Re: [Mesa-dev] [PATCH 19/29] glsl: Don't use strtod_l in Mesa on Android.

2014-08-01 Thread Emil Velikov
On 30/07/14 05:30, Ian Romanick wrote: > I think we should replace all the #ifdef garbage around this with a > HAVE_STRTOD_L macro. Having lots of platform knowledge sprinkled around > the code is ugly, at best. > Asking for the last guy to refactor it because the previous N people before him did

Re: [Mesa-dev] [PATCH 19/29] glsl: Don't use strtod_l in Mesa on Android.

2014-07-29 Thread Ian Romanick
I think we should replace all the #ifdef garbage around this with a HAVE_STRTOD_L macro. Having lots of platform knowledge sprinkled around the code is ugly, at best. Also... doesn't strtof_l (later in strtod.c) need the same treatment? On 07/29/2014 03:54 PM, Emil Velikov wrote: > From: "Myles

[Mesa-dev] [PATCH 19/29] glsl: Don't use strtod_l in Mesa on Android.

2014-07-29 Thread Emil Velikov
From: "Myles C. Maxfield" Android includes a fix to asm/posix_types.h inside /ndk/toolchains/x86-4.7/prebuilt/linux-x86_64/lib/gcc/ i686-linux-android/4.7/include-fixed/asm/posix_types.h. That file #include_next's the real asm/posix_types.h, but then fixes (redefines) the __FD_ZERO macro. However