Re: [Mesa-dev] [PATCH 18/23] targets/omx: convert to static/pipe-loader

2014-05-18 Thread Emil Velikov
On 18/05/14 09:14, Christian König wrote: > Am 18.05.2014 09:07, schrieb Emil Velikov: >> Similar to previous two commits. >> >> TODO: >> - Correctly set the role and profile names. >> >> Christian, >> >> * Recommendation about the following names ? >> - OMX_VID_{ENC,DEC}_BASE_NAME > > OMX.mes

Re: [Mesa-dev] [PATCH 18/23] targets/omx: convert to static/pipe-loader

2014-05-18 Thread Christian König
Am 18.05.2014 09:07, schrieb Emil Velikov: Similar to previous two commits. TODO: - Correctly set the role and profile names. Christian, * Recommendation about the following names ? - OMX_VID_{ENC,DEC}_BASE_NAME OMX.mesa.video_(decoder|encoder) - OMX_VID_{ENC,DEC}_{MPEG2,H264}_NAME

[Mesa-dev] [PATCH 18/23] targets/omx: convert to static/pipe-loader

2014-05-18 Thread Emil Velikov
Similar to previous two commits. TODO: - Correctly set the role and profile names. Christian, * Recommendation about the following names ? - OMX_VID_{ENC,DEC}_BASE_NAME - OMX_VID_{ENC,DEC}_{MPEG2,H264}_NAME * (Related) We do we strcpy string literals at vid_{enc,dec}_LoaderComponent. IMHO we