Re: [Mesa-dev] [PATCH 17/24] i965: Replace HW_REG with ARF/GRF.

2015-11-11 Thread Kenneth Graunke
On Monday, November 02, 2015 04:29:27 PM Matt Turner wrote: > HW_REGs are (were!) kind of awful. If the file was HW_REG, you had to > look at different fields for type, abs, negate, writemask, swizzle, and > a second file. They also caused annoying problems like immediate sources > being considered

Re: [Mesa-dev] [PATCH 17/24] i965: Replace HW_REG with ARF/GRF.

2015-11-03 Thread Matt Turner
On Tue, Nov 3, 2015 at 8:06 AM, Emil Velikov wrote: > On 3 November 2015 at 00:29, Matt Turner wrote: > >> @@ -422,7 +423,7 @@ fs_reg::fs_reg(uint8_t vf0, uint8_t vf1, uint8_t vf2, >> uint8_t vf3) >> fs_reg::fs_reg(struct brw_reg reg) : >> backend_reg(reg) >> { >> - this->file = HW_REG;

Re: [Mesa-dev] [PATCH 17/24] i965: Replace HW_REG with ARF/GRF.

2015-11-03 Thread Emil Velikov
On 3 November 2015 at 00:29, Matt Turner wrote: > @@ -422,7 +423,7 @@ fs_reg::fs_reg(uint8_t vf0, uint8_t vf1, uint8_t vf2, > uint8_t vf3) > fs_reg::fs_reg(struct brw_reg reg) : > backend_reg(reg) > { > - this->file = HW_REG; > + this->file = (enum register_file)reg.file; You're not ad

[Mesa-dev] [PATCH 17/24] i965: Replace HW_REG with ARF/GRF.

2015-11-02 Thread Matt Turner
HW_REGs are (were!) kind of awful. If the file was HW_REG, you had to look at different fields for type, abs, negate, writemask, swizzle, and a second file. They also caused annoying problems like immediate sources being considered scheduling barriers (commit 6148e94e2) and other such nonsense. In