Re: [Mesa-dev] [PATCH 16/23] readpix: raise priority of FBO completeness error

2013-01-10 Thread Ian Romanick
On 01/09/2013 12:47 PM, Jordan Justen wrote: On Tue, Jan 8, 2013 at 9:21 AM, Jordan Justen wrote: On Mon, Jan 7, 2013 at 1:19 PM, Ian Romanick wrote: On 01/04/2013 06:41 PM, Jordan Justen wrote: GTF/gles3 test suite wants this error to have higher priority than the type checking. If the

Re: [Mesa-dev] [PATCH 16/23] readpix: raise priority of FBO completeness error

2013-01-09 Thread Jordan Justen
On Tue, Jan 8, 2013 at 9:21 AM, Jordan Justen wrote: > On Mon, Jan 7, 2013 at 1:19 PM, Ian Romanick wrote: >> On 01/04/2013 06:41 PM, Jordan Justen wrote: >>> >>> GTF/gles3 test suite wants this error to have higher priority >>> than the type checking. >> >> >> If the ReadPixels call in the test

Re: [Mesa-dev] [PATCH 16/23] readpix: raise priority of FBO completeness error

2013-01-08 Thread Jordan Justen
On Mon, Jan 7, 2013 at 1:19 PM, Ian Romanick wrote: > On 01/04/2013 06:41 PM, Jordan Justen wrote: >> >> GTF/gles3 test suite wants this error to have higher priority >> than the type checking. > > > If the ReadPixels call in the test has multiple errors, the test should be > changed. There is no

Re: [Mesa-dev] [PATCH 16/23] readpix: raise priority of FBO completeness error

2013-01-07 Thread Ian Romanick
On 01/04/2013 06:41 PM, Jordan Justen wrote: GTF/gles3 test suite wants this error to have higher priority than the type checking. If the ReadPixels call in the test has multiple errors, the test should be changed. There is no requirement to generate a specific error when multiple problems e

[Mesa-dev] [PATCH 16/23] readpix: raise priority of FBO completeness error

2013-01-04 Thread Jordan Justen
GTF/gles3 test suite wants this error to have higher priority than the type checking. Signed-off-by: Jordan Justen --- src/mesa/main/readpix.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c index 8b1113c.