Re: [Mesa-dev] [PATCH 15/16] i965/fs: Add support for removing MOV.NZ instructions.

2015-01-20 Thread Jason Ekstrand
On Tue, Jan 20, 2015 at 4:02 PM, Matt Turner wrote: > On Tue, Jan 20, 2015 at 3:51 PM, Jason Ekstrand > wrote: > > Except typeless... We need some sort of assurance that the result of a > NIR > > comparison is always 0 or ~0. > > Help me understand how this is a different situation from what we

Re: [Mesa-dev] [PATCH 15/16] i965/fs: Add support for removing MOV.NZ instructions.

2015-01-20 Thread Matt Turner
On Tue, Jan 20, 2015 at 3:51 PM, Jason Ekstrand wrote: > Except typeless... We need some sort of assurance that the result of a NIR > comparison is always 0 or ~0. Help me understand how this is a different situation from what we have today? Let's take for instance a vec2 == vec2 comparison. On

Re: [Mesa-dev] [PATCH 15/16] i965/fs: Add support for removing MOV.NZ instructions.

2015-01-20 Thread Jason Ekstrand
On Tue, Jan 20, 2015 at 3:31 PM, Matt Turner wrote: > On Tue, Jan 20, 2015 at 3:17 PM, Jason Ekstrand > wrote: > > > > > > On Tue, Jan 20, 2015 at 3:09 PM, Matt Turner wrote: > >> > >> On Tue, Jan 20, 2015 at 2:58 PM, Jason Ekstrand > >> wrote: > >> > On Mon, Jan 19, 2015 at 3:31 PM, Matt Turn

Re: [Mesa-dev] [PATCH 15/16] i965/fs: Add support for removing MOV.NZ instructions.

2015-01-20 Thread Matt Turner
On Tue, Jan 20, 2015 at 3:17 PM, Jason Ekstrand wrote: > > > On Tue, Jan 20, 2015 at 3:09 PM, Matt Turner wrote: >> >> On Tue, Jan 20, 2015 at 2:58 PM, Jason Ekstrand >> wrote: >> > On Mon, Jan 19, 2015 at 3:31 PM, Matt Turner wrote: >> >> >> >> For some reason, we occasionally write the flag r

Re: [Mesa-dev] [PATCH 15/16] i965/fs: Add support for removing MOV.NZ instructions.

2015-01-20 Thread Jason Ekstrand
On Tue, Jan 20, 2015 at 3:09 PM, Matt Turner wrote: > On Tue, Jan 20, 2015 at 2:58 PM, Jason Ekstrand > wrote: > > On Mon, Jan 19, 2015 at 3:31 PM, Matt Turner wrote: > >> > >> For some reason, we occasionally write the flag register with a MOV.NZ > >> instruction: > >> > >>add(8)

Re: [Mesa-dev] [PATCH 15/16] i965/fs: Add support for removing MOV.NZ instructions.

2015-01-20 Thread Matt Turner
On Tue, Jan 20, 2015 at 2:58 PM, Jason Ekstrand wrote: > On Mon, Jan 19, 2015 at 3:31 PM, Matt Turner wrote: >> >> For some reason, we occasionally write the flag register with a MOV.NZ >> instruction: >> >>add(8) g25<1>F -g6<0,1,0>F g15<8,8,1>F >>cmp.l.f0(8) g26<

Re: [Mesa-dev] [PATCH 15/16] i965/fs: Add support for removing MOV.NZ instructions.

2015-01-20 Thread Jason Ekstrand
On Mon, Jan 19, 2015 at 3:31 PM, Matt Turner wrote: > For some reason, we occasionally write the flag register with a MOV.NZ > instruction: > >add(8) g25<1>F -g6<0,1,0>F g15<8,8,1>F >cmp.l.f0(8) g26<1>D g25<8,8,1>F 0F >mov.nz.f0(8)null

[Mesa-dev] [PATCH 15/16] i965/fs: Add support for removing MOV.NZ instructions.

2015-01-19 Thread Matt Turner
For some reason, we occasionally write the flag register with a MOV.NZ instruction: add(8) g25<1>F -g6<0,1,0>F g15<8,8,1>F cmp.l.f0(8) g26<1>D g25<8,8,1>F 0F mov.nz.f0(8)nullg26<8,8,1>D A MOV.NZ instruction on the result of a CMP is li