Re: [Mesa-dev] [PATCH 14/22] intel/compiler: Do image load/store lowering to NIR

2018-08-29 Thread Kenneth Graunke
On Wednesday, August 29, 2018 5:31:38 AM PDT Jason Ekstrand wrote: > On Wed, Aug 29, 2018 at 12:49 AM Kenneth Graunke > wrote: > > > On Friday, August 17, 2018 1:06:20 PM PDT Jason Ekstrand wrote: > > [snip] > > > +# Intel-specific query for loading from the brw_image_param struct > > passed > >

Re: [Mesa-dev] [PATCH 14/22] intel/compiler: Do image load/store lowering to NIR

2018-08-29 Thread Jason Ekstrand
On Wed, Aug 29, 2018 at 12:49 AM Kenneth Graunke wrote: > On Friday, August 17, 2018 1:06:20 PM PDT Jason Ekstrand wrote: > [snip] > > +# Intel-specific query for loading from the brw_image_param struct > passed > > +# into the shader as a uniform. The variable is a deref to the image > > +# var

Re: [Mesa-dev] [PATCH 14/22] intel/compiler: Do image load/store lowering to NIR

2018-08-28 Thread Kenneth Graunke
On Friday, August 17, 2018 1:06:20 PM PDT Jason Ekstrand wrote: [snip] > +# Intel-specific query for loading from the brw_image_param struct passed > +# into the shader as a uniform. The variable is a deref to the image > +# variable. The const index specifies which of the six parameters to load.

[Mesa-dev] [PATCH 14/22] intel/compiler: Do image load/store lowering to NIR

2018-08-17 Thread Jason Ekstrand
This commit moves our storage image format conversion codegen into NIR instead of doing it in the back-end. This has the advantage of letting us run it through NIR's optimizer which is pretty effective at shrinking things down. In the common case of rgba8, the number of instructions emitted after