Re: [Mesa-dev] [PATCH 14/16] i965/vec4: Turn some _mesa_problem calls into asserts

2015-06-22 Thread Ilia Mirkin
A very dangerous convention, IMO... it turns into infinite loops and other oddness in release builds. Should really just be done when it's really unreachable. (Perhaps that's the case here, dunno.) On Mon, Jun 22, 2015 at 11:21 PM, Chris Forbes wrote: > Recent convention has been to use unreachab

Re: [Mesa-dev] [PATCH 14/16] i965/vec4: Turn some _mesa_problem calls into asserts

2015-06-22 Thread Chris Forbes
Recent convention has been to use unreachable("str") rather than assert(!"str") On Tue, Jun 23, 2015 at 1:07 PM, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_vec4_vp.cpp | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw

[Mesa-dev] [PATCH 14/16] i965/vec4: Turn some _mesa_problem calls into asserts

2015-06-22 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_vec4_vp.cpp | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_vp.cpp b/src/mesa/drivers/dri/i965/brw_vec4_vp.cpp index 92d1085..dcbd240 100644 --- a/src/mesa/drivers/dri/i965/brw_vec4_vp.cpp +++ b/src/