Re: [Mesa-dev] [PATCH 14/15] intel: Refactor intel_screen_make_configs

2012-07-26 Thread Chad Versace
On 07/25/2012 11:11 AM, Eric Anholt wrote: > Chad Versace writes: > >> Transform the code from clever, obfuscated, and imperative to >> straight-forward and table-driven. > > I don't like this change. It increases the amount of code, and to > change any single option, you need to change more co

Re: [Mesa-dev] [PATCH 14/15] intel: Refactor intel_screen_make_configs

2012-07-26 Thread Chad Versace
On 07/23/2012 01:35 PM, Ian Romanick wrote: > On 07/21/2012 05:36 PM, Chad Versace wrote: >> Transform the code from clever, obfuscated, and imperative to >> straight-forward and table-driven. > > Does the output of glxinfo change? It's somewhat advantageous for the IDs > associated with a specif

Re: [Mesa-dev] [PATCH 14/15] intel: Refactor intel_screen_make_configs

2012-07-25 Thread Eric Anholt
Chad Versace writes: > Transform the code from clever, obfuscated, and imperative to > straight-forward and table-driven. I don't like this change. It increases the amount of code, and to change any single option, you need to change more code. If we were to change back_buffer_modes (and I thin

Re: [Mesa-dev] [PATCH 14/15] intel: Refactor intel_screen_make_configs

2012-07-23 Thread Ian Romanick
On 07/21/2012 05:36 PM, Chad Versace wrote: Transform the code from clever, obfuscated, and imperative to straight-forward and table-driven. Does the output of glxinfo change? It's somewhat advantageous for the IDs associated with a specific set of values to remain the same. We have a lot o

[Mesa-dev] [PATCH 14/15] intel: Refactor intel_screen_make_configs

2012-07-21 Thread Chad Versace
Transform the code from clever, obfuscated, and imperative to straight-forward and table-driven. CC: Ian Romanick Signed-off-by: Chad Versace --- src/mesa/drivers/dri/intel/intel_screen.c | 167 +- 1 file changed, 97 insertions(+), 70 deletions(-) diff --git a/src/m