Re: [Mesa-dev] [PATCH 13/21] i965: Resolve GCC sign-compare warning.

2015-08-05 Thread Rhys Kidd
Hello Ian, The other "i" is used within a for() loop below in that function. On review, I am inclined to resolve the underlying issue being shadowing a name within a broader scope, by changing the variable name of the GLuint. Either way, there were no piglit regressions on ILK. Will push as part

Re: [Mesa-dev] [PATCH 13/21] i965: Resolve GCC sign-compare warning.

2015-08-05 Thread Ian Romanick
On 08/02/2015 11:09 PM, Rhys Kidd wrote: > mesa/src/mesa/drivers/dri/i965/brw_draw_upload.c: In function > 'brw_prepare_vertices': > mesa/src/mesa/drivers/dri/i965/brw_draw_upload.c:434:22: warning: comparison > between signed and unsigned integer expressions [-Wsign-compare] > for (i = j = 0

[Mesa-dev] [PATCH 13/21] i965: Resolve GCC sign-compare warning.

2015-08-02 Thread Rhys Kidd
mesa/src/mesa/drivers/dri/i965/brw_draw_upload.c: In function 'brw_prepare_vertices': mesa/src/mesa/drivers/dri/i965/brw_draw_upload.c:434:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = j = 0; i < brw->vb.nr_enabled; i++) {