Re: [Mesa-dev] [PATCH 12/12] mesa/sso: Implement ValidateProgramPipeline

2014-03-15 Thread Eric Anholt
Ian Romanick writes: > On 03/13/2014 10:52 AM, Eric Anholt wrote: >> Ian Romanick writes: >> >>> -BEGIN PGP SIGNED MESSAGE- >>> Hash: SHA1 >>> >>> On 03/05/2014 01:00 PM, Eric Anholt wrote: Ian Romanick writes: > From: Gregory Hainaut > > Implementation note: I d

Re: [Mesa-dev] [PATCH 12/12] mesa/sso: Implement ValidateProgramPipeline

2014-03-15 Thread Ian Romanick
On 03/13/2014 10:52 AM, Eric Anholt wrote: > Ian Romanick writes: > >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> On 03/05/2014 01:00 PM, Eric Anholt wrote: >>> Ian Romanick writes: >>> From: Gregory Hainaut Implementation note: I don't use context for ralloc (don't k

Re: [Mesa-dev] [PATCH 12/12] mesa/sso: Implement ValidateProgramPipeline

2014-03-13 Thread Eric Anholt
Ian Romanick writes: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 03/05/2014 01:00 PM, Eric Anholt wrote: >> Ian Romanick writes: >> >>> From: Gregory Hainaut >>> >>> Implementation note: I don't use context for ralloc (don't know >>> how). >>> >>> The check on PROGRAM_SEPARABLE

Re: [Mesa-dev] [PATCH 12/12] mesa/sso: Implement ValidateProgramPipeline

2014-03-12 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/05/2014 01:00 PM, Eric Anholt wrote: > Ian Romanick writes: > >> From: Gregory Hainaut >> >> Implementation note: I don't use context for ralloc (don't know >> how). >> >> The check on PROGRAM_SEPARABLE flags is also done when the >> pipelin

Re: [Mesa-dev] [PATCH 12/12] mesa/sso: Implement ValidateProgramPipeline

2014-03-05 Thread Eric Anholt
Ian Romanick writes: > From: Gregory Hainaut > > Implementation note: > I don't use context for ralloc (don't know how). > > The check on PROGRAM_SEPARABLE flags is also done when the pipeline > isn't bound. It doesn't make any sense in a DSA style API. > > Maybe we could replace _mesa_validate

[Mesa-dev] [PATCH 12/12] mesa/sso: Implement ValidateProgramPipeline

2014-03-05 Thread Ian Romanick
From: Gregory Hainaut Implementation note: I don't use context for ralloc (don't know how). The check on PROGRAM_SEPARABLE flags is also done when the pipeline isn't bound. It doesn't make any sense in a DSA style API. Maybe we could replace _mesa_validate_program by _mesa_validate_program_pip