Re: [Mesa-dev] [PATCH 11/34] glsl: support compilation of geometry shaders

2013-07-31 Thread Paul Berry
On 31 July 2013 20:41, Kenneth Graunke wrote: > On 07/31/2013 05:16 PM, Ian Romanick wrote: > >> On 07/30/2013 03:16 PM, Kenneth Graunke wrote: >> >>> This code is getting ugly. It looks like the idea is to allocate two >>> (now three) separate arrays, but somebody decided to be "clever" and >>>

Re: [Mesa-dev] [PATCH 11/34] glsl: support compilation of geometry shaders

2013-07-31 Thread Kenneth Graunke
On 07/31/2013 05:16 PM, Ian Romanick wrote: On 07/30/2013 03:16 PM, Kenneth Graunke wrote: This code is getting ugly. It looks like the idea is to allocate two (now three) separate arrays, but somebody decided to be "clever" and batch them into a single calloc/free big enough to hold all of the

Re: [Mesa-dev] [PATCH 11/34] glsl: support compilation of geometry shaders

2013-07-31 Thread Ian Romanick
On 07/30/2013 03:16 PM, Kenneth Graunke wrote: On 07/28/2013 11:03 PM, Paul Berry wrote: From: Bryan Cain This commit adds all of the parsing and semantics for GLSL 150 style geometry shaders. v2 (Paul Berry ): Adjust i965's brw_link_shader() to pass the new is_geometry_shader argument to do_

Re: [Mesa-dev] [PATCH 11/34] glsl: support compilation of geometry shaders

2013-07-31 Thread Ian Romanick
On 07/28/2013 11:03 PM, Paul Berry wrote: From: Bryan Cain This commit adds all of the parsing and semantics for GLSL 150 style geometry shaders. v2 (Paul Berry ): Adjust i965's brw_link_shader() to pass the new is_geometry_shader argument to do_set_program_inouts. Add a few missing calls to

Re: [Mesa-dev] [PATCH 11/34] glsl: support compilation of geometry shaders

2013-07-31 Thread Paul Berry
On 30 July 2013 15:16, Kenneth Graunke wrote: > On 07/28/2013 11:03 PM, Paul Berry wrote: > >> @@ -112,14 +111,24 @@ >> ir_set_program_inouts_visitor::visit(ir_dereference_variable *ir) >> return visit_continue; >> >> if (ir->type->is_array()) { >> - mark(this->prog, ir->var, 0,

Re: [Mesa-dev] [PATCH 11/34] glsl: support compilation of geometry shaders

2013-07-30 Thread Paul Berry
On 30 July 2013 15:16, Kenneth Graunke wrote: > On 07/28/2013 11:03 PM, Paul Berry wrote: > >> + /* The 'varying in' and 'varying out' qualifiers can only be used >> with >> + * ARB_geometry_shader4 and EXT_geometry_shader4, which we don't >> support >> + * yet. >> + */ >>

Re: [Mesa-dev] [PATCH 11/34] glsl: support compilation of geometry shaders

2013-07-30 Thread Kenneth Graunke
On 07/28/2013 11:03 PM, Paul Berry wrote: From: Bryan Cain This commit adds all of the parsing and semantics for GLSL 150 style geometry shaders. v2 (Paul Berry ): Adjust i965's brw_link_shader() to pass the new is_geometry_shader argument to do_set_program_inouts. Add a few missing calls to

[Mesa-dev] [PATCH 11/34] glsl: support compilation of geometry shaders

2013-07-29 Thread Paul Berry
From: Bryan Cain This commit adds all of the parsing and semantics for GLSL 150 style geometry shaders. v2 (Paul Berry ): Adjust i965's brw_link_shader() to pass the new is_geometry_shader argument to do_set_program_inouts. Add a few missing calls to get_pipeline_stage(). Fix some signed/unsig