Re: [Mesa-dev] [PATCH 11/23] i965/gen8: Remove dead assertion

2016-02-10 Thread Pohjolainen, Topi
On Tue, Feb 09, 2016 at 03:40:07PM -0800, Ben Widawsky wrote: > On Mon, Feb 08, 2016 at 06:51:31PM +0200, Topi Pohjolainen wrote: > > The assertion is inside a condition mandating num_samples > 1 and > > therefore the first half of the constraint is always met. The > > second half in turn would onl

Re: [Mesa-dev] [PATCH 11/23] i965/gen8: Remove dead assertion

2016-02-09 Thread Ben Widawsky
On Mon, Feb 08, 2016 at 06:51:31PM +0200, Topi Pohjolainen wrote: > The assertion is inside a condition mandating num_samples > 1 and > therefore the first half of the constraint is always met. The > second half in turn would only be applicable for single sampled > case and moreover it is trying to

[Mesa-dev] [PATCH 11/23] i965/gen8: Remove dead assertion

2016-02-08 Thread Topi Pohjolainen
The assertion is inside a condition mandating num_samples > 1 and therefore the first half of the constraint is always met. The second half in turn would only be applicable for single sampled case and moreover it is trying to falsely check against surface type instead of format. Subsequent patches