Re: [Mesa-dev] [PATCH 11/22 v2] nir: Recognize some more open-coded fmin / fmax

2018-03-05 Thread Jason Ekstrand
On Mon, Mar 5, 2018 at 2:25 PM, Ian Romanick wrote: > On 03/05/2018 02:07 PM, Jason Ekstrand wrote: > > On Mon, Mar 5, 2018 at 11:11 AM, Ian Romanick > > wrote: > > > > On 02/28/2018 12:48 PM, Jason Ekstrand wrote: > > > Rb > > > > For both or just this o

Re: [Mesa-dev] [PATCH 11/22 v2] nir: Recognize some more open-coded fmin / fmax

2018-03-05 Thread Ian Romanick
On 03/05/2018 02:07 PM, Jason Ekstrand wrote: > On Mon, Mar 5, 2018 at 11:11 AM, Ian Romanick > wrote: > > On 02/28/2018 12:48 PM, Jason Ekstrand wrote: > > Rb > > For both or just this one? > > > If you put the ~ on there, both. I'm not sure what you

Re: [Mesa-dev] [PATCH 11/22 v2] nir: Recognize some more open-coded fmin / fmax

2018-03-05 Thread Jason Ekstrand
On Mon, Mar 5, 2018 at 11:11 AM, Ian Romanick wrote: > On 02/28/2018 12:48 PM, Jason Ekstrand wrote: > > Rb > > For both or just this one? > If you put the ~ on there, both. > > On Wed, Feb 28, 2018 at 12:18 PM, Ian Romanick > > wrote: > > > > From: Ian Romani

Re: [Mesa-dev] [PATCH 11/22 v2] nir: Recognize some more open-coded fmin / fmax

2018-03-05 Thread Ian Romanick
On 02/28/2018 12:48 PM, Jason Ekstrand wrote: > Rb For both or just this one? > On Wed, Feb 28, 2018 at 12:18 PM, Ian Romanick > wrote: > > From: Ian Romanick > > > This transformation is inexact because section 4.7.1 (

Re: [Mesa-dev] [PATCH 11/22 v2] nir: Recognize some more open-coded fmin / fmax

2018-02-28 Thread Jason Ekstrand
Rb On Wed, Feb 28, 2018 at 12:18 PM, Ian Romanick wrote: > From: Ian Romanick > > This transformation is inexact because section 4.7.1 (Range and > Precision) says: > > Operations and built-in functions that operate on a NaN are not > required to return a NaN as the result. > > The fmin

[Mesa-dev] [PATCH 11/22 v2] nir: Recognize some more open-coded fmin / fmax

2018-02-28 Thread Ian Romanick
From: Ian Romanick This transformation is inexact because section 4.7.1 (Range and Precision) says: Operations and built-in functions that operate on a NaN are not required to return a NaN as the result. The fmin or fmax might not return NaN in cases where the original expression would