Re: [Mesa-dev] [PATCH 10/24] glsl: Implement parser support for atomic counters.

2013-09-18 Thread Francisco Jerez
Ian Romanick writes: >[...] + if (field_type->atomic_size()) { +YYLTYPE loc = decl_list->get_location(); + _mesa_glsl_error(&loc, state, "atomic counter in structure or " + "uniform block"); + } + A

Re: [Mesa-dev] [PATCH 10/24] glsl: Implement parser support for atomic counters.

2013-09-18 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/18/2013 03:43 PM, Francisco Jerez wrote: > Ian Romanick writes: > >> On 09/17/2013 03:51 PM, Paul Berry wrote: >>> On 15 September 2013 00:10, Francisco Jerez >>> mailto:curroje...@riseup.net>> wrote: >>> [...] >>> >>> GLSL 4.20 clarifies tha

Re: [Mesa-dev] [PATCH 10/24] glsl: Implement parser support for atomic counters.

2013-09-18 Thread Francisco Jerez
Ian Romanick writes: > On 09/17/2013 03:51 PM, Paul Berry wrote: >> On 15 September 2013 00:10, Francisco Jerez > > wrote: >>[...] >> >> GLSL 4.20 clarifies that atomic counter offsets must be unique and >> non-overlapping (see GLSL 4.20 4.4.4.1 "Atomic Counter Layo

Re: [Mesa-dev] [PATCH 10/24] glsl: Implement parser support for atomic counters.

2013-09-18 Thread Francisco Jerez
Ian Romanick writes: > On 09/15/2013 02:10 AM, Francisco Jerez wrote: >>[...] >> >> >> +#include >> +#include > > No. We are not using STL or templates. > Any reason for it to be still so? Actually I started implementing this patch using one of mesa's hash tables, but at some point I rea

Re: [Mesa-dev] [PATCH 10/24] glsl: Implement parser support for atomic counters.

2013-09-18 Thread Ian Romanick
On 09/17/2013 03:51 PM, Paul Berry wrote: > On 15 September 2013 00:10, Francisco Jerez > wrote: > > --- > src/glsl/ast.h| 15 ++ > src/glsl/ast_to_hir.cpp | 68 > +-- > src/gl

Re: [Mesa-dev] [PATCH 10/24] glsl: Implement parser support for atomic counters.

2013-09-18 Thread Ian Romanick
On 09/15/2013 02:10 AM, Francisco Jerez wrote: > --- > src/glsl/ast.h| 15 ++ > src/glsl/ast_to_hir.cpp | 68 > +-- > src/glsl/ast_type.cpp | 13 +++-- > src/glsl/glsl_lexer.ll| 2 +- > src/glsl/glsl_parser

Re: [Mesa-dev] [PATCH 10/24] glsl: Implement parser support for atomic counters.

2013-09-17 Thread Francisco Jerez
Paul Berry writes: > On 15 September 2013 00:10, Francisco Jerez wrote: >[...] >> + } else if ((op[0]->type->atomic_size() || >> op[1]->type->atomic_size())) { >> +_mesa_glsl_error(&loc, state, "atomic counter comparisons >> forbidden"); >> +error_emitted = true; >> > > Do w

Re: [Mesa-dev] [PATCH 10/24] glsl: Implement parser support for atomic counters.

2013-09-17 Thread Paul Berry
On 15 September 2013 00:10, Francisco Jerez wrote: > --- > src/glsl/ast.h| 15 ++ > src/glsl/ast_to_hir.cpp | 68 > +-- > src/glsl/ast_type.cpp | 13 +++-- > src/glsl/glsl_lexer.ll| 2 +- > src/glsl/glsl_p

[Mesa-dev] [PATCH 10/24] glsl: Implement parser support for atomic counters.

2013-09-15 Thread Francisco Jerez
--- src/glsl/ast.h| 15 ++ src/glsl/ast_to_hir.cpp | 68 +-- src/glsl/ast_type.cpp | 13 +++-- src/glsl/glsl_lexer.ll| 2 +- src/glsl/glsl_parser.yy | 13 +++-- src/glsl/glsl_parser_extras.h | 10 +