Re: [Mesa-dev] [PATCH 10/21] i965/vec4: Address mul/mach constraints

2014-12-23 Thread Ben Widawsky
On Tue, Dec 23, 2014 at 10:45:27AM -0800, Matt Turner wrote: > On Mon, Dec 22, 2014 at 7:29 PM, Ben Widawsky > wrote: > > This patch addresses the errata on GEN8+ which disallows the mul/mach macro > > to > > have a modifier on src1. This was previously listed as a FINISHME. > > To be clear, I d

Re: [Mesa-dev] [PATCH 10/21] i965/vec4: Address mul/mach constraints

2014-12-23 Thread Matt Turner
On Mon, Dec 22, 2014 at 7:29 PM, Ben Widawsky wrote: > This patch addresses the errata on GEN8+ which disallows the mul/mach macro to > have a modifier on src1. This was previously listed as a FINISHME. To be clear, I don't think this is an errata. It's just a natural consequence of needing for f

[Mesa-dev] [PATCH 10/21] i965/vec4: Address mul/mach constraints

2014-12-22 Thread Ben Widawsky
This patch addresses the errata on GEN8+ which disallows the mul/mach macro to have a modifier on src1. This was previously listed as a FINISHME. Assertions for these cases will be added shortly. Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 23 +++