Re: [Mesa-dev] [PATCH 10/20] i965/fs: Implement image load, store and atomic.

2015-08-07 Thread Jason Ekstrand
On Fri, Jul 31, 2015 at 9:58 AM, Francisco Jerez wrote: > Jason Ekstrand writes: > >> On Fri, Jul 31, 2015 at 6:15 AM, Francisco Jerez >> wrote: >>> Jason Ekstrand writes: >>> On Thu, Jul 23, 2015 at 4:38 AM, Francisco Jerez wrote: > Jason Ekstrand writes: > >> This al

Re: [Mesa-dev] [PATCH 10/20] i965/fs: Implement image load, store and atomic.

2015-07-31 Thread Francisco Jerez
Jason Ekstrand writes: > On Fri, Jul 31, 2015 at 6:15 AM, Francisco Jerez > wrote: >> Jason Ekstrand writes: >> >>> On Thu, Jul 23, 2015 at 4:38 AM, Francisco Jerez >>> wrote: Jason Ekstrand writes: > This all looks correct as far as I can tell. However, I'm very > concer

Re: [Mesa-dev] [PATCH 10/20] i965/fs: Implement image load, store and atomic.

2015-07-31 Thread Jason Ekstrand
On Fri, Jul 31, 2015 at 6:15 AM, Francisco Jerez wrote: > Jason Ekstrand writes: > >> On Thu, Jul 23, 2015 at 4:38 AM, Francisco Jerez >> wrote: >>> Jason Ekstrand writes: >>> This all looks correct as far as I can tell. However, I'm very concerned about the number of checks such as

Re: [Mesa-dev] [PATCH 10/20] i965/fs: Implement image load, store and atomic.

2015-07-31 Thread Francisco Jerez
Jason Ekstrand writes: > On Thu, Jul 23, 2015 at 4:38 AM, Francisco Jerez > wrote: >> Jason Ekstrand writes: >> >>> This all looks correct as far as I can tell. However, I'm very >>> concerned about the number of checks such as >>> has_matching_typed_format() that are built-in to the compiler

Re: [Mesa-dev] [PATCH 10/20] i965/fs: Implement image load, store and atomic.

2015-07-30 Thread Jason Ekstrand
On Thu, Jul 23, 2015 at 4:38 AM, Francisco Jerez wrote: > Jason Ekstrand writes: > >> This all looks correct as far as I can tell. However, I'm very >> concerned about the number of checks such as >> has_matching_typed_format() that are built-in to the compiler (via >> surface_builder) where we

Re: [Mesa-dev] [PATCH 10/20] i965/fs: Implement image load, store and atomic.

2015-07-23 Thread Francisco Jerez
Jason Ekstrand writes: > This all looks correct as far as I can tell. However, I'm very > concerned about the number of checks such as > has_matching_typed_format() that are built-in to the compiler (via > surface_builder) where we then go on to do something that is highly > dependant on state s

Re: [Mesa-dev] [PATCH 10/20] i965/fs: Implement image load, store and atomic.

2015-07-22 Thread Jason Ekstrand
This all looks correct as far as I can tell. However, I'm very concerned about the number of checks such as has_matching_typed_format() that are built-in to the compiler (via surface_builder) where we then go on to do something that is highly dependant on state setup doing the exact same check (no

[Mesa-dev] [PATCH 10/20] i965/fs: Implement image load, store and atomic.

2015-07-21 Thread Francisco Jerez
v2: Drop VEC4 suport. v3: Rebase. --- .../drivers/dri/i965/brw_fs_surface_builder.cpp| 216 + src/mesa/drivers/dri/i965/brw_fs_surface_builder.h | 17 ++ 2 files changed, 233 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_surface_builder.cpp b/src/mesa/drive