Re: [Mesa-dev] [PATCH 10/19] etnaviv: GC7000: No RS align when using BLT

2017-11-05 Thread Christian Gmeiner
Reviewed-by: Christian Gmeiner 2017-11-05 16:23 GMT+01:00 Christian Gmeiner : > 2017-11-05 13:38 GMT+01:00 Wladimir : + if (!ctx->specs.use_blt) { + /* This (ab)uses the RS as a plain buffer memset(). + * Currently uses a fixed row size of 64 bytes. Some

Re: [Mesa-dev] [PATCH 10/19] etnaviv: GC7000: No RS align when using BLT

2017-11-05 Thread Christian Gmeiner
2017-11-05 13:38 GMT+01:00 Wladimir : >>> + if (!ctx->specs.use_blt) { >>> + /* This (ab)uses the RS as a plain buffer memset(). >>> + * Currently uses a fixed row size of 64 bytes. Some benchmarking >>> with >>> + * different sizes may be in order. */ >>> +

Re: [Mesa-dev] [PATCH 10/19] etnaviv: GC7000: No RS align when using BLT

2017-11-05 Thread Wladimir
>> + if (!ctx->specs.use_blt) { >> + /* This (ab)uses the RS as a plain buffer memset(). >> + * Currently uses a fixed row size of 64 bytes. Some benchmarking >> with >> + * different sizes may be in order. */ >> + struct etna_bo *ts_bo = etna_resource(surf->

Re: [Mesa-dev] [PATCH 10/19] etnaviv: GC7000: No RS align when using BLT

2017-11-05 Thread Christian Gmeiner
2017-10-30 17:16 GMT+01:00 Wladimir J. van der Laan : > RS align is not necessary and might even be harmful when using the BLT > engine for blitting. > > Signed-off-by: Wladimir J. van der Laan > --- > src/gallium/drivers/etnaviv/etnaviv_resource.c | 15 + > src/gallium/drivers/etnaviv/et

[Mesa-dev] [PATCH 10/19] etnaviv: GC7000: No RS align when using BLT

2017-10-30 Thread Wladimir J. van der Laan
RS align is not necessary and might even be harmful when using the BLT engine for blitting. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_resource.c | 15 + src/gallium/drivers/etnaviv/etnaviv_surface.c | 41 + src/gallium/driver