Re: [Mesa-dev] [PATCH 10/14] isl: Add support for HiZ surfaces

2016-07-15 Thread Nanley Chery
On Thu, Jul 14, 2016 at 04:18:33PM -0700, Jason Ekstrand wrote: > On Thu, Jul 14, 2016 at 4:13 PM, Nanley Chery wrote: > > > On Thu, Jul 14, 2016 at 03:57:09PM -0700, Jason Ekstrand wrote: > > > On Thu, Jul 14, 2016 at 3:45 PM, Nanley Chery > > wrote: > > > > > > > On Sat, Jul 09, 2016 at 12:17:

Re: [Mesa-dev] [PATCH 10/14] isl: Add support for HiZ surfaces

2016-07-14 Thread Jason Ekstrand
On Thu, Jul 14, 2016 at 4:13 PM, Nanley Chery wrote: > On Thu, Jul 14, 2016 at 03:57:09PM -0700, Jason Ekstrand wrote: > > On Thu, Jul 14, 2016 at 3:45 PM, Nanley Chery > wrote: > > > > > On Sat, Jul 09, 2016 at 12:17:28PM -0700, Jason Ekstrand wrote: > > > > --- > > > > src/intel/isl/isl.c

Re: [Mesa-dev] [PATCH 10/14] isl: Add support for HiZ surfaces

2016-07-14 Thread Nanley Chery
On Thu, Jul 14, 2016 at 03:57:09PM -0700, Jason Ekstrand wrote: > On Thu, Jul 14, 2016 at 3:45 PM, Nanley Chery wrote: > > > On Sat, Jul 09, 2016 at 12:17:28PM -0700, Jason Ekstrand wrote: > > > --- > > > src/intel/isl/isl.c | 11 +++ > > > src/intel/isl/isl.h

Re: [Mesa-dev] [PATCH 10/14] isl: Add support for HiZ surfaces

2016-07-14 Thread Jason Ekstrand
On Thu, Jul 14, 2016 at 3:45 PM, Nanley Chery wrote: > On Sat, Jul 09, 2016 at 12:17:28PM -0700, Jason Ekstrand wrote: > > --- > > src/intel/isl/isl.c | 11 +++ > > src/intel/isl/isl.h | 17 + > > src/intel/isl/isl_format_layout.csv | 1 +

Re: [Mesa-dev] [PATCH 10/14] isl: Add support for HiZ surfaces

2016-07-14 Thread Nanley Chery
On Sat, Jul 09, 2016 at 12:17:28PM -0700, Jason Ekstrand wrote: > --- > src/intel/isl/isl.c | 11 +++ > src/intel/isl/isl.h | 17 + > src/intel/isl/isl_format_layout.csv | 1 + > src/intel/isl/isl_gen6.c| 8 > src/intel

Re: [Mesa-dev] [PATCH 10/14] isl: Add support for HiZ surfaces

2016-07-13 Thread Chad Versace
On Tue 12 Jul 2016, Jason Ekstrand wrote: > On Jul 12, 2016 4:14 PM, "Chad Versace" wrote: > > > > On Tue 12 Jul 2016, Jason Ekstrand wrote: > > > On Tue, Jul 12, 2016 at 2:36 PM, Chad Versace > > > wrote: > > > > > > > Also, isl.c needs an update in this hunk: > > > > > > > ># isl.c > > > >

Re: [Mesa-dev] [PATCH 10/14] isl: Add support for HiZ surfaces

2016-07-12 Thread Jason Ekstrand
On Jul 12, 2016 4:14 PM, "Chad Versace" wrote: > > On Tue 12 Jul 2016, Jason Ekstrand wrote: > > On Tue, Jul 12, 2016 at 2:36 PM, Chad Versace > > wrote: > > > > > Also, isl.c needs an update in this hunk: > > > > > ># isl.c > > >if (isl_surf_usage_is_depth_or_stencil(info->usage)) { > >

Re: [Mesa-dev] [PATCH 10/14] isl: Add support for HiZ surfaces

2016-07-12 Thread Chad Versace
On Tue 12 Jul 2016, Jason Ekstrand wrote: > On Tue, Jul 12, 2016 at 2:36 PM, Chad Versace > wrote: > > > I believe isl_gen7.c needs more updates: > > > > static uint32_t > > gen7_choose_halign_el(const struct isl_device *dev, > > const struct isl_surf_init_info *

Re: [Mesa-dev] [PATCH 10/14] isl: Add support for HiZ surfaces

2016-07-12 Thread Chad Versace
On Tue 12 Jul 2016, Jason Ekstrand wrote: > On Tue, Jul 12, 2016 at 2:36 PM, Chad Versace > wrote: > > > Also, isl.c needs an update in this hunk: > > > ># isl.c > >if (isl_surf_usage_is_depth_or_stencil(info->usage)) { > > /* From the Ivybridge PRM >> Volume 1 Part 1: Graphics Core

Re: [Mesa-dev] [PATCH 10/14] isl: Add support for HiZ surfaces

2016-07-12 Thread Chad Versace
On Tue 12 Jul 2016, Jason Ekstrand wrote: > On Tue, Jul 12, 2016 at 2:36 PM, Chad Versace > wrote: > > > TODO: hiz in script > > > > Thanks to the script being rewritten in a *sane* programming language, > there's nothing to change. Oops. That TODO was a comment to myself. What's wrong with aw

Re: [Mesa-dev] [PATCH 10/14] isl: Add support for HiZ surfaces

2016-07-12 Thread Jason Ekstrand
On Tue, Jul 12, 2016 at 2:36 PM, Chad Versace wrote: > On Sat 09 Jul 2016, Jason Ekstrand wrote: > > --- > > src/intel/isl/isl.c | 11 +++ > > src/intel/isl/isl.h | 17 + > > src/intel/isl/isl_format_layout.csv | 1 + > > src/intel/isl/isl

Re: [Mesa-dev] [PATCH 10/14] isl: Add support for HiZ surfaces

2016-07-12 Thread Jason Ekstrand
On Tue, Jul 12, 2016 at 2:36 PM, Chad Versace wrote: > On Sat 09 Jul 2016, Jason Ekstrand wrote: > > --- > > src/intel/isl/isl.c | 11 +++ > > src/intel/isl/isl.h | 17 + > > src/intel/isl/isl_format_layout.csv | 1 + > > src/intel/isl/isl

Re: [Mesa-dev] [PATCH 10/14] isl: Add support for HiZ surfaces

2016-07-12 Thread Jason Ekstrand
On Tue, Jul 12, 2016 at 2:36 PM, Chad Versace wrote: > On Sat 09 Jul 2016, Jason Ekstrand wrote: > > --- > > src/intel/isl/isl.c | 11 +++ > > src/intel/isl/isl.h | 17 + > > src/intel/isl/isl_format_layout.csv | 1 + > > src/intel/isl/isl

Re: [Mesa-dev] [PATCH 10/14] isl: Add support for HiZ surfaces

2016-07-12 Thread Chad Versace
On Sat 09 Jul 2016, Jason Ekstrand wrote: > --- > src/intel/isl/isl.c | 11 +++ > src/intel/isl/isl.h | 17 + > src/intel/isl/isl_format_layout.csv | 1 + > src/intel/isl/isl_gen6.c| 8 > src/intel/isl/isl_gen7.c

Re: [Mesa-dev] [PATCH 10/14] isl: Add support for HiZ surfaces

2016-07-11 Thread Pohjolainen, Topi
On Sat, Jul 09, 2016 at 12:17:28PM -0700, Jason Ekstrand wrote: > --- > src/intel/isl/isl.c | 11 +++ > src/intel/isl/isl.h | 17 + > src/intel/isl/isl_format_layout.csv | 1 + > src/intel/isl/isl_gen6.c| 8 > src/intel

[Mesa-dev] [PATCH 10/14] isl: Add support for HiZ surfaces

2016-07-09 Thread Jason Ekstrand
--- src/intel/isl/isl.c | 11 +++ src/intel/isl/isl.h | 17 + src/intel/isl/isl_format_layout.csv | 1 + src/intel/isl/isl_gen6.c| 8 src/intel/isl/isl_gen7.c| 10 +- src/intel/isl/isl_gen8.c