Re: [Mesa-dev] [PATCH 1/9] panfrost: Get rid of ctx->job

2019-08-02 Thread Boris Brezillon
On Fri, 2 Aug 2019 07:59:02 -0700 Alyssa Rosenzweig wrote: > Theoretically we were supposed to set ctx->job to the current job, I > guess cacheing the result of panfrost_get_job_for_fbo() > > See v3d's implementation which this is a carbon clone of. Okay, so it's something we want to have to av

Re: [Mesa-dev] [PATCH 1/9] panfrost: Get rid of ctx->job

2019-08-02 Thread Alyssa Rosenzweig
Theoretically we were supposed to set ctx->job to the current job, I guess cacheing the result of panfrost_get_job_for_fbo() See v3d's implementation which this is a carbon clone of. On Fri, Aug 02, 2019 at 12:12:49PM +0200, Boris Brezillon wrote: > This field is never set to anything but NULL, w

[Mesa-dev] [PATCH 1/9] panfrost: Get rid of ctx->job

2019-08-02 Thread Boris Brezillon
This field is never set to anything but NULL, which means the test done in panfrost_free_job() and panfrost_get_job_for_fbo() will always evaluate to false. Let's get rid of this field. Signed-off-by: Boris Brezillon --- src/gallium/drivers/panfrost/pan_context.h | 3 +-- src/gallium/drivers/pan