[Mesa-dev] [PATCH 1/8] vbo: Correctly handle attribute offsets in dlist draw.

2018-01-31 Thread Mathias . Froehlich
From: Mathias Fröhlich When executing a display list draw, for the offset list to be correct, the offset computation needs to accumulate all attribute size values in order. Specifically, if we are shuffling around the position and generic0 attributes, we may violate the order or if we do not walk

Re: [Mesa-dev] [PATCH 1/8] vbo: Correctly handle attribute offsets in dlist draw.

2018-01-31 Thread Mathias Fröhlich
Hi Brian, On Wednesday, 31 January 2018 17:54:55 CET Brian Paul wrote: > Nice work! It's nice to get rid of some of those attribute loops. > The series looks good to me, just assorted nit-picks and comments on a > few patches. Thanks! Past this 8 patches we still have O(VERT_ATTRIB_MAX) loops.

Re: [Mesa-dev] [PATCH 1/8] vbo: Correctly handle attribute offsets in dlist draw.

2018-01-31 Thread Brian Paul
On 01/31/2018 09:54 AM, Brian Paul wrote: Hi Matthias, Nice work!  It's nice to get rid of some of those attribute loops. The series looks good to me, just assorted nit-picks and comments on a few patches. Oh, and it might be good to write a new piglit test or two to exercise the POS/GENERIC

Re: [Mesa-dev] [PATCH 1/8] vbo: Correctly handle attribute offsets in dlist draw.

2018-01-31 Thread Brian Paul
Hi Matthias, Nice work! It's nice to get rid of some of those attribute loops. The series looks good to me, just assorted nit-picks and comments on a few patches. -Brian On 01/31/2018 12:55 AM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich When executing a display list draw, fo

[Mesa-dev] [PATCH 1/8] vbo: Correctly handle attribute offsets in dlist draw.

2018-01-30 Thread Mathias . Froehlich
From: Mathias Fröhlich When executing a display list draw, for the offset list to be correct, the offset computation needs to accumulate all attribute size values in order. Specifically, if we are shuffling around the position and generic0 attributes, we may violate the order or if we do not walk