[Mesa-dev] [PATCH 1/8] glsl: calculate number of operands in an expression once

Extra validation is added to ir_validate to make sure this is always updated to the correct numer of operands, as passes like lower_instructions modify the instructions directly rather then generating a new one. The reduction in time is so small that it is not really measurable. However callgrind

Re: [Mesa-dev] [PATCH 1/8] glsl: calculate number of operands in an expression once

On 09/08/17 05:59, Thomas Helland wrote: I'm not quite sure if the increase in size of the base ir class versus the reduced overhead and added code is worth it? There is more code yes, but most of that is asserts and validation code. This should actually make the code more robust than it is cu

Re: [Mesa-dev] [PATCH 1/8] glsl: calculate number of operands in an expression once

I'm not quite sure if the increase in size of the base ir class versus the reduced overhead and added code is worth it? Some numbers would be nice. A comment below 2017-08-07 2:18 GMT+00:00 Timothy Arceri : > Extra validation is added to ir_validate to make sure this is > always updated to the cor

[Mesa-dev] [PATCH 1/8] glsl: calculate number of operands in an expression once

Extra validation is added to ir_validate to make sure this is always updated to the correct numer of operands, as passes like lower_instructions modify the instructions directly rather then generating a new one. --- src/compiler/glsl/glsl_to_nir.cpp | 4 +-- src/compiler/glsl/ir.