Re: [Mesa-dev] [PATCH 1/7] nir: add nir_var_all enum

2015-11-06 Thread Jason Ekstrand
On Fri, Nov 6, 2015 at 8:35 AM, Rob Clark wrote: > Otherwise, passing -1 gets you: > > error: invalid conversion from 'int' to 'nir_variable_mode' [-fpermissive] > > Signed-off-by: Rob Clark > --- > I was going to convert the enum values to bitmask/flags which could > be OR'd, but that doesn't

[Mesa-dev] [PATCH 1/7] nir: add nir_var_all enum

2015-11-06 Thread Rob Clark
Otherwise, passing -1 gets you: error: invalid conversion from 'int' to 'nir_variable_mode' [-fpermissive] Signed-off-by: Rob Clark --- I was going to convert the enum values to bitmask/flags which could be OR'd, but that doesn't play nicely w/ nir_variable::data which tries to stuff this into

Re: [Mesa-dev] [PATCH 1/7] nir: add nir_var_all enum

2015-10-26 Thread Rob Clark
On Mon, Oct 26, 2015 at 1:56 PM, Jason Ekstrand wrote: > On Sat, Oct 24, 2015 at 10:07 AM, Rob Clark wrote: >> Otherwise, passing -1 gets you: >> >> error: invalid conversion from 'int' to 'nir_variable_mode' [-fpermissive] > > Yeah, I've never really liked that. Another option (which I think

Re: [Mesa-dev] [PATCH 1/7] nir: add nir_var_all enum

2015-10-26 Thread Jason Ekstrand
On Sat, Oct 24, 2015 at 10:07 AM, Rob Clark wrote: > Otherwise, passing -1 gets you: > > error: invalid conversion from 'int' to 'nir_variable_mode' [-fpermissive] Yeah, I've never really liked that. Another option (which I think I'd marginally prefer) would be to make nir_lower_io take a bitf

[Mesa-dev] [PATCH 1/7] nir: add nir_var_all enum

2015-10-24 Thread Rob Clark
Otherwise, passing -1 gets you: error: invalid conversion from 'int' to 'nir_variable_mode' [-fpermissive] Signed-off-by: Rob Clark --- src/glsl/nir/nir.c | 4 src/glsl/nir/nir.h | 1 + src/glsl/nir/nir_lower_io.c | 2 +- src/mesa/drivers/dri/i96