Re: [Mesa-dev] [PATCH 1/6] mesa: Create a _mesa_bitcount_64() function.

2011-10-04 Thread Paul Berry
On 4 October 2011 09:41, Kenneth Graunke wrote: > On 10/04/2011 07:00 AM, Brian Paul wrote: > > > > I'm guessing you could eventually get rid of the brw_count_bits() > > wrapper altogether at some point. > > > > Reviewed-by: Brian Paul > > I'd be glad to see that go, too. > > Reviewed-by: Kennet

Re: [Mesa-dev] [PATCH 1/6] mesa: Create a _mesa_bitcount_64() function.

2011-10-04 Thread Kenneth Graunke
On 10/04/2011 07:00 AM, Brian Paul wrote: > On 10/03/2011 04:11 PM, Paul Berry wrote: >> The i965 driver already had a function to do this (brw_count_bits()), >> but it was buggy (it only counted the bottom 32 bits) and it was >> clumsy (it had a strange and broken fallback for non-GCC-like >> comp

Re: [Mesa-dev] [PATCH 1/6] mesa: Create a _mesa_bitcount_64() function.

2011-10-04 Thread Brian Paul
On 10/03/2011 04:11 PM, Paul Berry wrote: The i965 driver already had a function to do this (brw_count_bits()), but it was buggy (it only counted the bottom 32 bits) and it was clumsy (it had a strange and broken fallback for non-GCC-like compilers, which fortunately was never used). Since Mesa

[Mesa-dev] [PATCH 1/6] mesa: Create a _mesa_bitcount_64() function.

2011-10-03 Thread Paul Berry
The i965 driver already had a function to do this (brw_count_bits()), but it was buggy (it only counted the bottom 32 bits) and it was clumsy (it had a strange and broken fallback for non-GCC-like compilers, which fortunately was never used). Since Mesa already has a _mesa_bitcount() function, it