Re: [Mesa-dev] [PATCH 1/6] i965: Don't force a header for texture offsets of 0.

2016-04-23 Thread Jason Ekstrand
Reviewed-by Jason Ekstrand The rest of the patches look just as good to me now as when I wrote them, but you can't very well call that a review. :-p On Apr 23, 2016 4:39 PM, "Kenneth Graunke" wrote: > Calling textureOffset() with an offset of <0, 0, 0> is equivalent to > calliing texture(). We

[Mesa-dev] [PATCH 1/6] i965: Don't force a header for texture offsets of 0.

2016-04-23 Thread Kenneth Graunke
Calling textureOffset() with an offset of <0, 0, 0> is equivalent to calliing texture(). We don't actually need to set up an offset, which causes a message header to be created. A fairly common pattern is to sample at a point with a bunch of offsets, and average them. It's natural to write all t