[Mesa-dev] [PATCH 1/6] i965: Consolidate certain miptree params to flags

2015-06-08 Thread Ben Widawsky
I think pretty much everyone agrees that having more than a single bool as a function argument is bordering on a bad idea. What sucks about the current code is in several instances it's necessary to propagate these boolean selections down to lower layers of the code. This requires plumbing (mechani

Re: [Mesa-dev] [PATCH 1/6] i965: Consolidate certain miptree params to flags

2015-06-04 Thread Ben Widawsky
On Fri, May 29, 2015 at 12:07:36PM -0700, Chad Versace wrote: > On Fri 29 May 2015, Pohjolainen, Topi wrote: > > On Fri, May 29, 2015 at 09:32:53AM +0300, Pohjolainen, Topi wrote: > > > On Thu, May 28, 2015 at 10:21:29AM -0700, Ben Widawsky wrote: > > > > I think pretty much everyone agrees that ha

Re: [Mesa-dev] [PATCH 1/6] i965: Consolidate certain miptree params to flags

2015-06-01 Thread Matt Turner
On Fri, May 29, 2015 at 12:33 PM, Chad Versace wrote: > On Fri 29 May 2015, Matt Turner wrote: >> On Thu, May 28, 2015 at 10:21 AM, Ben Widawsky >> > @@ -286,7 +284,7 @@ intel_miptree_create_layout(struct brw_context *brw, >> > mt->logical_height0 = height0; >> > mt->logical_depth0 = depth

Re: [Mesa-dev] [PATCH 1/6] i965: Consolidate certain miptree params to flags

2015-05-29 Thread Chad Versace
On Fri 29 May 2015, Kenneth Graunke wrote: > On Friday, May 29, 2015 12:33:10 PM Chad Versace wrote: > > On Fri 29 May 2015, Matt Turner wrote: > > > On Thu, May 28, 2015 at 10:21 AM, Ben Widawsky > > > > @@ -286,7 +284,7 @@ intel_miptree_create_layout(struct brw_context *brw, > > > > mt->logic

Re: [Mesa-dev] [PATCH 1/6] i965: Consolidate certain miptree params to flags

2015-05-29 Thread Kenneth Graunke
On Friday, May 29, 2015 12:33:10 PM Chad Versace wrote: > On Fri 29 May 2015, Matt Turner wrote: > > On Thu, May 28, 2015 at 10:21 AM, Ben Widawsky > > > @@ -286,7 +284,7 @@ intel_miptree_create_layout(struct brw_context *brw, > > > mt->logical_height0 = height0; > > > mt->logical_depth0 =

Re: [Mesa-dev] [PATCH 1/6] i965: Consolidate certain miptree params to flags

2015-05-29 Thread Chad Versace
On Fri 29 May 2015, Matt Turner wrote: > On Thu, May 28, 2015 at 10:21 AM, Ben Widawsky > > @@ -286,7 +284,7 @@ intel_miptree_create_layout(struct brw_context *brw, > > mt->logical_height0 = height0; > > mt->logical_depth0 = depth0; > > mt->fast_clear_state = INTEL_FAST_CLEAR_STATE_NO_M

Re: [Mesa-dev] [PATCH 1/6] i965: Consolidate certain miptree params to flags

2015-05-29 Thread Matt Turner
On Thu, May 28, 2015 at 10:21 AM, Ben Widawsky wrote: > I think pretty much everyone agrees that having more than a single bool as a > function argument is bordering on a bad idea. What sucks about the current > code is in several instances it's necessary to propagate these boolean > selections do

Re: [Mesa-dev] [PATCH 1/6] i965: Consolidate certain miptree params to flags

2015-05-29 Thread Chad Versace
On Fri 29 May 2015, Pohjolainen, Topi wrote: > On Fri, May 29, 2015 at 09:32:53AM +0300, Pohjolainen, Topi wrote: > > On Thu, May 28, 2015 at 10:21:29AM -0700, Ben Widawsky wrote: > > > I think pretty much everyone agrees that having more than a single bool > > > as a > > > function argument is bo

Re: [Mesa-dev] [PATCH 1/6] i965: Consolidate certain miptree params to flags

2015-05-28 Thread Pohjolainen, Topi
On Fri, May 29, 2015 at 09:32:53AM +0300, Pohjolainen, Topi wrote: > On Thu, May 28, 2015 at 10:21:29AM -0700, Ben Widawsky wrote: > > I think pretty much everyone agrees that having more than a single bool as a > > function argument is bordering on a bad idea. What sucks about the current > > code

Re: [Mesa-dev] [PATCH 1/6] i965: Consolidate certain miptree params to flags

2015-05-28 Thread Pohjolainen, Topi
On Thu, May 28, 2015 at 10:21:29AM -0700, Ben Widawsky wrote: > I think pretty much everyone agrees that having more than a single bool as a > function argument is bordering on a bad idea. What sucks about the current > code is in several instances it's necessary to propagate these boolean > select

Re: [Mesa-dev] [PATCH 1/6] i965: Consolidate certain miptree params to flags

2015-05-28 Thread Anuj Phogat
On Thu, May 28, 2015 at 10:21 AM, Ben Widawsky wrote: > I think pretty much everyone agrees that having more than a single bool as a > function argument is bordering on a bad idea. What sucks about the current > code is in several instances it's necessary to propagate these boolean > selections do

[Mesa-dev] [PATCH 1/6] i965: Consolidate certain miptree params to flags

2015-05-28 Thread Ben Widawsky
I think pretty much everyone agrees that having more than a single bool as a function argument is bordering on a bad idea. What sucks about the current code is in several instances it's necessary to propagate these boolean selections down to lower layers of the code. This requires plumbing (mechani