Re: [Mesa-dev] [PATCH 1/6] glsl: Clean up apply_implicit_conversion

2014-04-27 Thread Chris Forbes
On Sun, Apr 27, 2014 at 9:44 PM, Chris Forbes wrote: > + /* Prior to GLSL 1.10, there are no implicit conversions */ Oops, botched the comment. Will fix. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/li

[Mesa-dev] [PATCH 1/6] glsl: Clean up apply_implicit_conversion

2014-04-27 Thread Chris Forbes
We're about to add new implicit conversions, first for ARB_gpu_shader5, and then later for ARB_gpu_shader_fp64. Pull out the opcode determination into its own function, and get rid of the bool -> float case that could never be hit anyway [since it fails the is_numeric() check]. Signed-off-by: Chri