Re: [Mesa-dev] [PATCH 1/6] gallium: plumb context priority through to driver

2017-10-09 Thread Andres Rodriguez
On 2017-10-05 11:29 AM, Nicolai Hähnle wrote: On 04.10.2017 23:02, Rob Clark wrote: On Wed, Oct 4, 2017 at 3:33 PM, Roland Scheidegger wrote: Am 04.10.2017 um 17:44 schrieb Rob Clark: Signed-off-by: Rob Clark ---   src/gallium/drivers/etnaviv/etnaviv_screen.c    |  1 +   src/gallium/dr

Re: [Mesa-dev] [PATCH 1/6] gallium: plumb context priority through to driver

2017-10-05 Thread Nicolai Hähnle
On 04.10.2017 23:02, Rob Clark wrote: On Wed, Oct 4, 2017 at 3:33 PM, Roland Scheidegger wrote: Am 04.10.2017 um 17:44 schrieb Rob Clark: Signed-off-by: Rob Clark --- src/gallium/drivers/etnaviv/etnaviv_screen.c| 1 + src/gallium/drivers/freedreno/freedreno_screen.c| 1 + sr

Re: [Mesa-dev] [PATCH 1/6] gallium: plumb context priority through to driver

2017-10-05 Thread Wladimir J. van der Laan
On Wed, Oct 04, 2017 at 11:44:32AM -0400, Rob Clark wrote: > Signed-off-by: Rob Clark Reviewed etnaviv change only. Reviewed-by: Wladimir J. van der Laan > --- > src/gallium/drivers/etnaviv/etnaviv_screen.c| 1 + > src/gallium/drivers/freedreno/freedreno_screen.c| 1 + > src/gal

Re: [Mesa-dev] [PATCH 1/6] gallium: plumb context priority through to driver

2017-10-04 Thread Andres Rodriguez
This should be good for radeonsi to implement the feature as well. FWIW: Reviewed-by: Andres Rodriguez Little bikeshed comment. I'm a little iffy about using a mask instead of an enum for priority values. It limits the flexibility on the number of levels drastically. Since you can't really b

Re: [Mesa-dev] [PATCH 1/6] gallium: plumb context priority through to driver

2017-10-04 Thread Rob Clark
On Wed, Oct 4, 2017 at 3:33 PM, Roland Scheidegger wrote: > Am 04.10.2017 um 17:44 schrieb Rob Clark: >> Signed-off-by: Rob Clark >> --- >> src/gallium/drivers/etnaviv/etnaviv_screen.c| 1 + >> src/gallium/drivers/freedreno/freedreno_screen.c| 1 + >> src/gallium/drivers/i915/i915_

Re: [Mesa-dev] [PATCH 1/6] gallium: plumb context priority through to driver

2017-10-04 Thread Marek Olšák
What others said, and yes radeonsi shouldn't expose the extension. Other than those: Reviewed-by: Marek Olšák Marek On Wed, Oct 4, 2017 at 5:44 PM, Rob Clark wrote: > Signed-off-by: Rob Clark > --- > src/gallium/drivers/etnaviv/etnaviv_screen.c| 1 + > src/gallium/drivers/freedreno/

Re: [Mesa-dev] [PATCH 1/6] gallium: plumb context priority through to driver

2017-10-04 Thread Roland Scheidegger
Am 04.10.2017 um 17:44 schrieb Rob Clark: > Signed-off-by: Rob Clark > --- > src/gallium/drivers/etnaviv/etnaviv_screen.c| 1 + > src/gallium/drivers/freedreno/freedreno_screen.c| 1 + > src/gallium/drivers/i915/i915_screen.c | 1 + > src/gallium/drivers/llvmpipe/lp_sc

Re: [Mesa-dev] [PATCH 1/6] gallium: plumb context priority through to driver

2017-10-04 Thread Brian Paul
On 10/04/2017 09:44 AM, Rob Clark wrote: Signed-off-by: Rob Clark --- src/gallium/drivers/etnaviv/etnaviv_screen.c| 1 + src/gallium/drivers/freedreno/freedreno_screen.c| 1 + src/gallium/drivers/i915/i915_screen.c | 1 + src/gallium/drivers/llvmpipe/lp_screen.c

[Mesa-dev] [PATCH 1/6] gallium: plumb context priority through to driver

2017-10-04 Thread Rob Clark
Signed-off-by: Rob Clark --- src/gallium/drivers/etnaviv/etnaviv_screen.c| 1 + src/gallium/drivers/freedreno/freedreno_screen.c| 1 + src/gallium/drivers/i915/i915_screen.c | 1 + src/gallium/drivers/llvmpipe/lp_screen.c| 1 + src/gallium/drivers/nouveau/