Re: [Mesa-dev] [PATCH 1/5] i965: Move program key structures to brw_program.h.

2014-12-01 Thread Chris Forbes
For the series: Reviewed-by: Chris Forbes On Mon, Dec 1, 2014 at 11:00 PM, Kenneth Graunke wrote: > With fs_visitor/fs_generator being reused for SIMD8 VS/GS programs, > we're running into weird #include patterns, where scalar code #includes > brw_vec4.h and such. > > Program keys aren't really

[Mesa-dev] [PATCH 1/5] i965: Move program key structures to brw_program.h.

2014-12-01 Thread Kenneth Graunke
With fs_visitor/fs_generator being reused for SIMD8 VS/GS programs, we're running into weird #include patterns, where scalar code #includes brw_vec4.h and such. Program keys aren't really related to SIMD4X2/SIMD8 execution - they mostly capture NOS for a particular shader stage. Consolidating the