Re: [Mesa-dev] [PATCH 1/5] i965/fs: Don't CSE negated multiplies with saturation.

2016-02-22 Thread Ian Romanick
Patches 1 - 4 are Reviewed-by: Ian Romanick Patch 5 probably is too, but I have a question or two. On 02/22/2016 04:13 PM, Matt Turner wrote: > It's not correct to CSE these multiplies > >mul.sat dst1, -a, b >mul.sat dst2, a, b > > by emitting a negated MOV from dst1 to dst2: > >

[Mesa-dev] [PATCH 1/5] i965/fs: Don't CSE negated multiplies with saturation.

2016-02-22 Thread Matt Turner
It's not correct to CSE these multiplies mul.sat dst1, -a, b mul.sat dst2, a, b by emitting a negated MOV from dst1 to dst2: mul.sat dst1, -a, b mov dst2, -dst1 Take 2.0*2.0 for example. The first multiply would produce 0.0 and the second would produce 1.0. Fixes bad generated