Re: [Mesa-dev] [PATCH 1/5] anv: Disable stencil writes when both write masks are zero

2017-02-08 Thread Nanley Chery
On Tue, Feb 07, 2017 at 04:53:51PM -0800, Jason Ekstrand wrote: > On Tue, Feb 7, 2017 at 3:14 PM, Jason Ekstrand wrote: > > > Here's the new commit message: > > > > Vulkan doesn't have a stencilWriteEnable bit like it does for depth. > > Instead, you have a stencil mask. Since the stenci

Re: [Mesa-dev] [PATCH 1/5] anv: Disable stencil writes when both write masks are zero

2017-02-07 Thread Jason Ekstrand
On Tue, Feb 7, 2017 at 3:14 PM, Jason Ekstrand wrote: > Here's the new commit message: > > Vulkan doesn't have a stencilWriteEnable bit like it does for depth. > Instead, you have a stencil mask. Since the stencil mask is handled as > dynamic state, we have to handle it later during

Re: [Mesa-dev] [PATCH 1/5] anv: Disable stencil writes when both write masks are zero

2017-02-07 Thread Jason Ekstrand
Here's the new commit message: Vulkan doesn't have a stencilWriteEnable bit like it does for depth. Instead, you have a stencil mask. Since the stencil mask is handled as dynamic state, we have to handle it later during command buffer construction. This helps Dota2 by a couple pe

Re: [Mesa-dev] [PATCH 1/5] anv: Disable stencil writes when both write masks are zero

2017-02-07 Thread Nanley Chery
On Tue, Feb 07, 2017 at 12:25:18PM -0800, Jason Ekstrand wrote: > On Tue, Feb 7, 2017 at 12:13 PM, Nanley Chery wrote: > > > On Wed, Feb 01, 2017 at 08:07:22PM -0800, Jason Ekstrand wrote: > > > The only mechanism Vulkan provides for disabling stencil writes is to set > > > > This isn't the only

Re: [Mesa-dev] [PATCH 1/5] anv: Disable stencil writes when both write masks are zero

2017-02-07 Thread Jason Ekstrand
On Tue, Feb 7, 2017 at 12:13 PM, Nanley Chery wrote: > On Wed, Feb 01, 2017 at 08:07:22PM -0800, Jason Ekstrand wrote: > > The only mechanism Vulkan provides for disabling stencil writes is to set > > This isn't the only mechanism for explicitly disabling stencil writes. > Stencil writes can also

Re: [Mesa-dev] [PATCH 1/5] anv: Disable stencil writes when both write masks are zero

2017-02-07 Thread Nanley Chery
On Wed, Feb 01, 2017 at 08:07:22PM -0800, Jason Ekstrand wrote: > The only mechanism Vulkan provides for disabling stencil writes is to set This isn't the only mechanism for explicitly disabling stencil writes. Stencil writes can also be disabled by disabling stencil testing (as can be seen in thi

Re: [Mesa-dev] [PATCH 1/5] anv: Disable stencil writes when both write masks are zero

2017-02-02 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 02/02/17 04:07, Jason Ekstrand wrote: The only mechanism Vulkan provides for disabling stencil writes is to set the stencil write mask to 0. Since that is dynamic state, we have to move handle it late during command buffer builder. This helps Dota2 by a coupl

[Mesa-dev] [PATCH 1/5] anv: Disable stencil writes when both write masks are zero

2017-02-01 Thread Jason Ekstrand
The only mechanism Vulkan provides for disabling stencil writes is to set the stencil write mask to 0. Since that is dynamic state, we have to move handle it late during command buffer builder. This helps Dota2 by a couple percent because it allows the hardware to move the depth and stencil write

[Mesa-dev] [PATCH 1/5] anv: Disable stencil writes when both write masks are zero

2017-02-01 Thread Jason Ekstrand
The only mechanism Vulkan provides for disabling stencil writes is to set the stencil write mask to 0. Since that is dynamic state, we have to move handle it late during command buffer builder. This helps Dota2 by a couple percent because it allows the hardware to move the depth and stencil write