Re: [Mesa-dev] [PATCH 1/4] radeonsi/compute: directly emit CONTEXT_CONTROL

2014-09-26 Thread Marek Olšák
On Fri, Sep 26, 2014 at 3:04 PM, Alex Deucher wrote: > On Thu, Sep 25, 2014 at 3:02 PM, Tom Stellard wrote: >> On Mon, Sep 22, 2014 at 09:48:43PM +0200, Marek Olšák wrote: >>> No, we cannot detect compute-only contexts yet. We need to add a new >>> parameter to pipe_context::context_create which

Re: [Mesa-dev] [PATCH 1/4] radeonsi/compute: directly emit CONTEXT_CONTROL

2014-09-26 Thread Alex Deucher
On Thu, Sep 25, 2014 at 3:02 PM, Tom Stellard wrote: > On Mon, Sep 22, 2014 at 09:48:43PM +0200, Marek Olšák wrote: >> No, we cannot detect compute-only contexts yet. We need to add a new >> parameter to pipe_context::context_create which says that a context is >> compute-only. That should be Open

Re: [Mesa-dev] [PATCH 1/4] radeonsi/compute: directly emit CONTEXT_CONTROL

2014-09-26 Thread Christian König
How about assuming for each CS that it can use the compute ring and as soon as we submit a PM4 command that can only be executed on the graphics ring note that this CS needs to be executed on the graphics ring? Just an idea, Christian. Am 25.09.2014 um 21:02 schrieb Tom Stellard: On Mon, Sep

Re: [Mesa-dev] [PATCH 1/4] radeonsi/compute: directly emit CONTEXT_CONTROL

2014-09-25 Thread Tom Stellard
On Mon, Sep 22, 2014 at 09:48:43PM +0200, Marek Olšák wrote: > No, we cannot detect compute-only contexts yet. We need to add a new > parameter to pipe_context::context_create which says that a context is > compute-only. That should be OpenCL but not OpenGL. > > Also, some code paths like resource

Re: [Mesa-dev] [PATCH 1/4] radeonsi/compute: directly emit CONTEXT_CONTROL

2014-09-23 Thread Tom Stellard
On Sat, Sep 20, 2014 at 12:11:02PM +0200, Marek Olšák wrote: > From: Marek Olšák Patches 1-3 are: Reviewed-by: Tom Stellard > > --- > src/gallium/drivers/radeonsi/si_compute.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/radeonsi/si_compu

Re: [Mesa-dev] [PATCH 1/4] radeonsi/compute: directly emit CONTEXT_CONTROL

2014-09-22 Thread Marek Olšák
No, we cannot detect compute-only contexts yet. We need to add a new parameter to pipe_context::context_create which says that a context is compute-only. That should be OpenCL but not OpenGL. Also, some code paths like resource_copy_region use the graphics engine for copying, which cannot be used

Re: [Mesa-dev] [PATCH 1/4] radeonsi/compute: directly emit CONTEXT_CONTROL

2014-09-22 Thread Niels Ole Salscheider
On Monday 22 September 2014, 12:16:13, Alex Deucher wrote: > On Sat, Sep 20, 2014 at 6:11 AM, Marek Olšák wrote: > > From: Marek Olšák > > Looks good. Tom should probably take a look as well. As a further > improvement, it would be nice to be able to use the compute rings for > compute rather

Re: [Mesa-dev] [PATCH 1/4] radeonsi/compute: directly emit CONTEXT_CONTROL

2014-09-22 Thread Alex Deucher
On Sat, Sep 20, 2014 at 6:11 AM, Marek Olšák wrote: > From: Marek Olšák > Looks good. Tom should probably take a look as well. As a further improvement, it would be nice to be able to use the compute rings for compute rather than gfx, but I'm not sure how much additional effort it would take t

Re: [Mesa-dev] [PATCH 1/4] radeonsi/compute: directly emit CONTEXT_CONTROL

2014-09-22 Thread Michel Dänzer
The series looks good to me, but Tom should probably take a look as well. -- Earthling Michel Dänzer| http://www.amd.com Libre software enthusiast |Mesa and X developer ___ mesa-dev mailing list me

[Mesa-dev] [PATCH 1/4] radeonsi/compute: directly emit CONTEXT_CONTROL

2014-09-20 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_compute.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/si_compute.c index 4b2662d..3ad9182 100644 --- a/src/gallium/drivers/radeonsi/si_comp