Re: [Mesa-dev] [PATCH 1/4] nir: add support for min/max/median of 3 srcs

2018-03-09 Thread Samuel Pitoiset
For the series: Reviewed-by: Samuel Pitoiset On 03/08/2018 11:14 PM, Daniel Schürmann wrote: From: Dave Airlie These are needed for SPV_AMD_shader_trinary_minmax, the AMD HW supports these. Co-authored-by: Daniel Schürmann Signed-off-by: Dave Airlie --- src/compiler/nir/nir_opcodes.py |

Re: [Mesa-dev] [PATCH 1/4] nir: add support for min/max/median of 3 srcs

2018-03-08 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick I think we should also add a flag for lowering this instruction as is done in GLSL IR. You should then add some patterns to nir_opt_algebraic.py that recognize open-code versions. It would also be interesting to detect clamp() patterns and convert them t

[Mesa-dev] [PATCH 1/4] nir: add support for min/max/median of 3 srcs

2018-03-08 Thread Daniel Schürmann
From: Dave Airlie These are needed for SPV_AMD_shader_trinary_minmax, the AMD HW supports these. Co-authored-by: Daniel Schürmann Signed-off-by: Dave Airlie --- src/compiler/nir/nir_opcodes.py | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/compiler/nir/nir_opcodes.py