Re: [Mesa-dev] [PATCH 1/4] nir: Add a small pass to rematerialize derefs per-block

2018-09-19 Thread Jason Ekstrand
Looks good On September 19, 2018 22:18:56 "Juan A. Suarez Romero" wrote: On Mon, 2018-09-17 at 09:43 -0500, Jason Ekstrand wrote: This pass re-materializes deref instructions on a per-block basis to ensure that every use of a deref occurs in the same block as the instruction which uses it.

Re: [Mesa-dev] [PATCH 1/4] nir: Add a small pass to rematerialize derefs per-block

2018-09-19 Thread Juan A. Suarez Romero
On Mon, 2018-09-17 at 09:43 -0500, Jason Ekstrand wrote: > This pass re-materializes deref instructions on a per-block basis to > ensure that every use of a deref occurs in the same block as the > instruction which uses it. Hello! This patch was commited CCing to 18.2 stable branch. This patch d

Re: [Mesa-dev] [PATCH 1/4] nir: Add a small pass to rematerialize derefs per-block

2018-09-18 Thread Iago Toral
On Tue, 2018-09-18 at 07:27 -0500, Jason Ekstrand wrote: > On Tue, Sep 18, 2018 at 4:11 AM Iago Toral wrote: > > Hi Jason, > > > > > > > > I left a few comments in patches 1 and 4, feel free to ignore them > > if > > > > you think they are not relevant. Either way the series is: > > I would l

Re: [Mesa-dev] [PATCH 1/4] nir: Add a small pass to rematerialize derefs per-block

2018-09-18 Thread Jason Ekstrand
On Tue, Sep 18, 2018 at 4:11 AM Iago Toral wrote: > Hi Jason, > > I left a few comments in patches 1 and 4, feel free to ignore them if > you think they are not relevant. Either way the series is: > I would like to back-port this to 18.2 if you don't mind. I think it's far more accurate than wh

Re: [Mesa-dev] [PATCH 1/4] nir: Add a small pass to rematerialize derefs per-block

2018-09-18 Thread Iago Toral
Hi Jason, I left a few comments in patches 1 and 4, feel free to ignore them if you think they are not relevant. Either way the series is: Reviewed-by: Iago Toral Quiroga On Mon, 2018-09-17 at 09:43 -0500, Jason Ekstrand wrote: > This pass re-materializes deref instructions on a per-block basis

Re: [Mesa-dev] [PATCH 1/4] nir: Add a small pass to rematerialize derefs per-block

2018-09-18 Thread Iago Toral
On Mon, 2018-09-17 at 09:43 -0500, Jason Ekstrand wrote: > This pass re-materializes deref instructions on a per-block basis to > ensure that every use of a deref occurs in the same block as the > instruction which uses it. > --- > src/compiler/nir/nir.h | 1 + > src/compiler/nir/nir_deref

[Mesa-dev] [PATCH 1/4] nir: Add a small pass to rematerialize derefs per-block

2018-09-17 Thread Jason Ekstrand
This pass re-materializes deref instructions on a per-block basis to ensure that every use of a deref occurs in the same block as the instruction which uses it. --- src/compiler/nir/nir.h | 1 + src/compiler/nir/nir_deref.c | 132 +++ 2 files changed, 133 in