Re: [Mesa-dev] [PATCH 1/4] linker: Trivial coding standards fixes

2016-11-09 Thread Ian Romanick
On 11/08/2016 05:25 AM, Ilia Mirkin wrote: > On Tue, Nov 8, 2016 at 12:50 AM, Ian Romanick wrote: >> - virtual void visit_field(const glsl_type *type, const char *name, >> -bool row_major) >> + virtual void visit_field(const glsl_type *, const char *, >> +

Re: [Mesa-dev] [PATCH 1/4] linker: Trivial coding standards fixes

2016-11-08 Thread Ilia Mirkin
On Tue, Nov 8, 2016 at 12:50 AM, Ian Romanick wrote: > - virtual void visit_field(const glsl_type *type, const char *name, > -bool row_major) > + virtual void visit_field(const glsl_type *, const char *, > +bool /* row_major */) > { >

Re: [Mesa-dev] [PATCH 1/4] linker: Trivial coding standards fixes

2016-11-08 Thread Kenneth Graunke
On Monday, November 7, 2016 9:50:38 PM PST Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/compiler/glsl/link_uniforms.cpp | 30 ++ > 1 file changed, 14 insertions(+), 16 deletions(-) Patches 1-3 are Reviewed-by: Kenneth Graunke

[Mesa-dev] [PATCH 1/4] linker: Trivial coding standards fixes

2016-11-07 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/compiler/glsl/link_uniforms.cpp | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/src/compiler/glsl/link_uniforms.cpp b/src/compiler/glsl/link_uniforms.cpp index b3c3c5a..fdcbd36 100644 --