Re: [Mesa-dev] [PATCH 1/4] intel/decoder: tools: gen_engine enum location

2018-10-30 Thread Toni Lönnberg
I was thinking the exact same thing earlier but I didn't feel like changing too much of what was already there, thus keeping the enum. Can change it use the definition from uapi for v2. On Tue, Oct 30, 2018 at 02:58:28PM +, Lionel Landwerlin wrote: > I think we should switch to use drm_i915_

Re: [Mesa-dev] [PATCH 1/4] intel/decoder: tools: gen_engine enum location

2018-10-30 Thread Lionel Landwerlin
I think we should switch to use drm_i915_gem_engine_class from include/drm-uapi/i915_drm.h and just have macro for class id -> mask. On 30/10/2018 14:32, Toni Lönnberg wrote: Moved the engine enum from aub_read.h to gen_decoder.h and changed it into a bitmask. The enumeration needs to be define

[Mesa-dev] [PATCH 1/4] intel/decoder: tools: gen_engine enum location

2018-10-30 Thread Toni Lönnberg
Moved the engine enum from aub_read.h to gen_decoder.h and changed it into a bitmask. The enumeration needs to be defined in a single place that can be used by the decoder and tools. --- src/intel/common/gen_decoder.h | 6 ++ src/intel/tools/aub_read.c | 1 + src/intel/tools/aub_read.h