Re: [Mesa-dev] [PATCH 1/4] glsl: add component to has_layout() helper

2016-02-09 Thread Ian Romanick
Patches 1, 2, and 4 are Reviewed-by: Ian Romanick Pending the result of the Khronos spec bug, patch 3 is also R-b. On 01/12/2016 01:34 AM, Timothy Arceri wrote: > I don't think this will do much as it's a compiler error > to use component without location which is already in the > table but its

Re: [Mesa-dev] [PATCH 1/4] glsl: add component to has_layout() helper

2016-02-09 Thread Samuel Iglesias Gonsálvez
Reviewed-by: Samuel Iglesias Gonsálvez On Tue, 2016-01-12 at 20:34 +1100, Timothy Arceri wrote: > I don't think this will do much as it's a compiler error > to use component without location which is already in the > table but its good to be consistent. > --- >  src/glsl/ast_type.cpp | 1 + >  1 f

[Mesa-dev] [PATCH 1/4] glsl: add component to has_layout() helper

2016-01-12 Thread Timothy Arceri
I don't think this will do much as it's a compiler error to use component without location which is already in the table but its good to be consistent. --- src/glsl/ast_type.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/glsl/ast_type.cpp b/src/glsl/ast_type.cpp index 7330a34..6d6f88f