Re: [Mesa-dev] [PATCH 1/3] radeonsi: assert that the DB format is valid (v2)

2012-11-15 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Thu, Nov 15, 2012 at 5:46 PM, wrote: > From: Alex Deucher > > Rather than disabling the depth buffer. > > v2: use INVALID hw format rather than ~0U > > Signed-off-by: Alex Deucher > --- > src/gallium/drivers/radeonsi/si_state.c | 13 +

Re: [Mesa-dev] [PATCH 1/3] radeonsi: assert that the DB format is valid (v2)

2012-11-15 Thread Michel Dänzer
On Don, 2012-11-15 at 17:58 +0100, Michel Dänzer wrote: > On Don, 2012-11-15 at 11:46 -0500, alexdeuc...@gmail.com wrote: > > From: Alex Deucher > > > > Rather than disabling the depth buffer. > > How about doing both? The assertions will be useful for debugging cases > that aren't handled pro

Re: [Mesa-dev] [PATCH 1/3] radeonsi: assert that the DB format is valid (v2)

2012-11-15 Thread Michel Dänzer
On Don, 2012-11-15 at 11:46 -0500, alexdeuc...@gmail.com wrote: > From: Alex Deucher > > Rather than disabling the depth buffer. How about doing both? The assertions will be useful for debugging cases that aren't handled properly, but disabling the CB/DB buffers could avoid trouble in those cas

[Mesa-dev] [PATCH 1/3] radeonsi: assert that the DB format is valid (v2)

2012-11-15 Thread alexdeucher
From: Alex Deucher Rather than disabling the depth buffer. v2: use INVALID hw format rather than ~0U Signed-off-by: Alex Deucher --- src/gallium/drivers/radeonsi/si_state.c | 13 + 1 files changed, 5 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_sta