On 15.11.2012 19:14, Marek Olšák wrote:
On Thu, Nov 15, 2012 at 5:28 PM, Christian König
wrote:
On 15.11.2012 17:00, alexdeuc...@gmail.com wrote:
From: Alex Deucher
Rather than disabling the depth buffer.
I would still prefer to use *_INVALID as the invalid function return value
here.
Just
For the series:
Reviewed-by: Marek Olšák
Marek
On Thu, Nov 15, 2012 at 5:46 PM, wrote:
> From: Alex Deucher
>
> Rather than disabling the depth buffer.
>
> v2: use INVALID hw format rather than ~0U
>
> Signed-off-by: Alex Deucher
> ---
> src/gallium/drivers/radeonsi/si_state.c | 13 +
On Thu, Nov 15, 2012 at 5:28 PM, Christian König
wrote:
> On 15.11.2012 17:00, alexdeuc...@gmail.com wrote:
>>
>> From: Alex Deucher
>>
>> Rather than disabling the depth buffer.
>
> I would still prefer to use *_INVALID as the invalid function return value
> here.
>
> Just imagine a release buil
On Don, 2012-11-15 at 17:58 +0100, Michel Dänzer wrote:
> On Don, 2012-11-15 at 11:46 -0500, alexdeuc...@gmail.com wrote:
> > From: Alex Deucher
> >
> > Rather than disabling the depth buffer.
>
> How about doing both? The assertions will be useful for debugging cases
> that aren't handled pro
On Don, 2012-11-15 at 11:46 -0500, alexdeuc...@gmail.com wrote:
> From: Alex Deucher
>
> Rather than disabling the depth buffer.
How about doing both? The assertions will be useful for debugging cases
that aren't handled properly, but disabling the CB/DB buffers could
avoid trouble in those cas
From: Alex Deucher
Rather than disabling the depth buffer.
v2: use INVALID hw format rather than ~0U
Signed-off-by: Alex Deucher
---
src/gallium/drivers/radeonsi/si_state.c | 13 +
1 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_sta
On 15.11.2012 17:00, alexdeuc...@gmail.com wrote:
From: Alex Deucher
Rather than disabling the depth buffer.
I would still prefer to use *_INVALID as the invalid function return
value here.
Just imagine a release build with an undetected bug, writing *_INVALID
would still result in well def
From: Alex Deucher
Rather than disabling the depth buffer.
Signed-off-by: Alex Deucher
---
src/gallium/drivers/radeonsi/si_state.c |9 +++--
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_state.c
b/src/gallium/drivers/radeonsi/si_state.c
